Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81303
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.218.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54C8BB29.7040703@gmail.com>
References: <54C80F4F.7020905@gmail.com>
	<CAEPJdu=g81B36MCOfyseBxJhm-S68bcNvkHUkNLjkMGYi5GxVA@mail.gmail.com>
	<54C8BB29.7040703@gmail.com>
Date: Wed, 28 Jan 2015 13:43:53 +0200
Message-ID: <CAPhkiZxd4yOA42Va9unzzYGCkvMTOVKssXU=wjCz_W4aMve=3g@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Proposal: Raise severity of undefined constants
From: narf@devilix.net (Andrey Andreev)

HI,

On Wed, Jan 28, 2015 at 12:34 PM, Rowan Collins <rowan.collins@gmail.com> wrote:
> Benjamin Eberlei wrote on 28/01/2015 08:43:
>>
>> I think this is too big a BC break.
>>
>> The usage of $array[key] = 0 instead of "key" is widespread.
>
>
> As I mentioned, the advice *not* to write that has been in the manual since
> 2001, so I can't think why any tutorial or example code would teach it as
> the right way, but it is possible, I suppose.
>
> I realise the majority of code is not available publicly, but it would be
> good to make some attempt to judge whether it really is widespread, so if
> you have any examples or way of measuring it, that would be useful.

From what I've seen, most developers seem to put everything in quotes
- strings (obviously), integers, floats, even numeric array keys ...
boolean and null being the only exceptions (but I've seen that too).

No opinion on the subject, just my observations.

Cheers,
Andrey.