Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:8130
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
To: internals@lists.php.net
In-Reply-To: <1781292779406.20040225234401@marcus-boerger.de>
References: <1077748616.685.16.camel@localhost>
	 <1781292779406.20040225234401@marcus-boerger.de>
Content-Type: text/plain
Message-ID: <1077749539.685.27.camel@localhost>
Mime-Version: 1.0
Date: Wed, 25 Feb 2004 23:52:20 +0100
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible
	with that of Foo::__construct()
From: thekid@thekid.de (Timm Friebe)

On Wed, 2004-02-25 at 23:44, Marcus Boerger wrote:
> Hello Timm,
> 
> i had the same expirience today too. And also for me it makes not much
> sense. The constructor shouldn't check inheritance rules.

Neither should other methods follow this. What if I want to add a
non-default parameter to an overriden method?

<?php
  class Foo {
    function connect($server) {
    }
  }
  
  class Bar extends Foo {
    function connect($server, $port) {
    }
  }
?>

I see where the problem comes from:

zend_do_perform_implementation_check() is called from
do_inherit_method_check() (both in zend_compile.c) which in turn is
called for inheritance *and* for interfaces. The behaviour is fully
desirable when implementing interfaces but not for regular inheritance.

- Timm