Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81293
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.171 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGa2bXaBUdH4dbkaLc3_S1gJQ42B=RHLTt7iGNRh_P-MCKXX=A@mail.gmail.com>
References: <CAGa2bXYXuQ6hhbzTMne7SgErFfKfJ01w5RquAgA4GBAAzN7hAA@mail.gmail.com>
 <CAPg3XxLNF1zzKU_L8kk0cdZzDPgc7qcBh6RRWEJBHar3Dc3Niw@mail.gmail.com>
 <CAGa2bXYzEP1n0EnEgZwXy8kwH3Asnj=bMTSkrPRrkd0D2BcMMQ@mail.gmail.com>
 <CAGa2bXY_R6E0qd_t4DzES76LeR6XebgA-U6Rcqr0rwMR2O8OEw@mail.gmail.com>
 <CAGa2bXZ0_GjWz=041b3UP8saQEpk7UNafYx2Con-hFXd+hn0zQ@mail.gmail.com> <CAGa2bXaBUdH4dbkaLc3_S1gJQ42B=RHLTt7iGNRh_P-MCKXX=A@mail.gmail.com>
Date: Wed, 28 Jan 2015 18:36:04 +0900
Message-ID: <CAGa2bXbNxyRSYNcEKXZ=dZ5CuBDmPPvXL-MiyjFq2-89W7htnA@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113d6f641c7f2d050db31c7b
Subject: Re: [PHP-DEV] [VOTE] RFC: Introduce session_start() options -
 read_only, unsafe_lock, lazy_write and lazy_destroy
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a113d6f641c7f2d050db31c7b
Content-Type: text/plain; charset=UTF-8

Hi all,

On Mon, Jan 26, 2015 at 6:42 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> On Thu, Jan 22, 2015 at 2:05 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
>> I've made patch for master since PHP 5.6 is released already.
>>
>> https://wiki.php.net/rfc/session-lock-ini
>> https://github.com/php/php-src/pull/1016
>>
>> Except comments, changes are almost minimal, but includes a few bug fixes
>> that tests equality of PS(session_status) against "php_session_none". The
>> comparison must be "PS(session_status) != php_session_active" as it has
>> php_session_disabled. I also removed 2 needless session globals.
>>
>> Comments are appreciated.
>> This patch boosts PHP application performance a lot when session data
>> have not changed. It's faster than benchmark in the wiki because hashing
>> has removed.
>>
>> If I don't have any comment in a few days, I'll merge it to master.
>>
>
> I've updated UPGRADING and UPGRADING.INTERNALS and ready to merge.
> I'll wait a day more. Please comment on github if you have.
>


I've tried to get some benchmarks. It seems current system is too fast to
get obvious performance difference.

Test command: ab -c 7 -n 500000 http://localhost:8888/session.php

Test script:
<?php
ini_set('session.save_path', '/home/tmp');
ini_set('session.lazy_write', 1); // Change mode here
ini_set('session.use_strict_mode', 0);

session_id('testid');
session_start(['read_and_close'=>0]); // Change mode here
//$_SESSION['test'] = ++$_SESSION['test'];
$_SESSION['a'] = str_repeat('a', 102400);
echo '<pre>';
var_dump(session_id(), $_SESSION['test']);
?>


Old behavior was around 15000 reqs/sec.

"read_and_close" improved it to about 20000 reqs/sec. i.e 33% faster.

"lazy_write" did not improve # of reqs, but per process httpd disk writes
was reduced from 100 MB/s to 5 MB/s. i.e. There were 12 httpd processes,
1200 MB/s writes was reduced to 60 MB/s writes. Note: Linux kernel(btrfs)
does not actually write data to disk when the data is the same.

I think this would be good enough benchmark for merging.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a113d6f641c7f2d050db31c7b--