Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:81282 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89628 invoked from network); 28 Jan 2015 05:42:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jan 2015 05:42:57 -0000 Authentication-Results: pb1.pair.com header.from=mails@thomasbley.de; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=mails@thomasbley.de; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain thomasbley.de from 85.13.137.24 cause and error) X-PHP-List-Original-Sender: mails@thomasbley.de X-Host-Fingerprint: 85.13.137.24 dd15934.kasserver.com Received: from [85.13.137.24] ([85.13.137.24:55171] helo=dd15934.kasserver.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3E/C6-45774-FD678C45 for ; Wed, 28 Jan 2015 00:42:56 -0500 Received: from dd15934.kasserver.com (dd0802.kasserver.com [85.13.143.1]) by dd15934.kasserver.com (Postfix) with ESMTPSA id 2A22C261376; Wed, 28 Jan 2015 06:42:53 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-SenderIP: 95.90.232.102 User-Agent: ALL-INKL Webmail 2.11 In-Reply-To: <54C7EA44.2080307@gmail.com> References: <20150127024521.3689F2618FD@dd15934.kasserver.com> <54C7EA44.2080307@gmail.com> To: laruence@php.net, yohgaki@ohgaki.net, smalyshev@gmail.com Cc: internals@lists.php.net, nicolas.grekas+php@gmail.com, reeze@php.net Message-ID: <20150128054253.2A22C261376@dd15934.kasserver.com> Date: Wed, 28 Jan 2015 06:42:53 +0100 (CET) Subject: Re: [PHP-DEV][RFC] Enable error_handler callback parameters to be passed by reference From: mails@thomasbley.de ("Thomas Bley") Hi, the idea behind the rfc is not to change error messages, it's only to append useful information to them. Changing lines/filenames is surely something controversial and might be only useful when compiling configuration files or templates to php code. Therefore we have 3 options in the voting section. > Maybe better access to logging system for custom logging would be more > efficient instead? The logging system can be accessed with 1 line of code (trigger_error, throw new exception, etc), so from userland perspective I don't see any deficits here. In case someone needs multiple error handlers, it might be necessary to implement sth. like spl_set_error_handler (similar to spl_autoload_register), but that's not in the scope of this rfc. Regards Thomas Stanislav Malyshev wrote on 27.01.2015 20:43: > Hi! > >> I feel it's kindof wrong direction. >> >> if you want custom logs, maybe you should use custom logger. > > Same here, API basing on modifying something that is supposed to be > internal engine things feels wrong, even if it does work. Changing error > message is borderline, changing things like lines/filenames just feels > wrong. > > Maybe better access to logging system for custom logging would be more > efficient instead? > > -- > Stas Malyshev > smalyshev@gmail.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >