Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:81277 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 76070 invoked from network); 28 Jan 2015 03:46:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jan 2015 03:46:02 -0000 X-Host-Fingerprint: 85.223.116.227 227-116.citynet.ftth.internl.net Received: from [85.223.116.227] ([85.223.116.227:8725] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7A/D4-45774-77B58C45 for ; Tue, 27 Jan 2015 22:46:01 -0500 To: internals@lists.php.net Date: Wed, 28 Jan 2015 04:45:55 +0100 Message-ID: References: X-Newsreader: Forte Agent 3.3/32.846 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Posted-By: 85.223.116.227 Subject: Re: imagick on PHP 7 was Stepping stones to a working php7 ... From: phpdev@ehrhardt.nl (Jan Ehrhardt) Dan Ackroyd in php.internals (Mon, 26 Jan 2015 17:58:40 +0000): >On 26 January 2015 at 00:02, Lester Caine wrote: >> /imagick ... need to get a copy to work with > >Imagick is now working on 7; you will need to use the PHP 7 branch >from https://github.com/mkoppanen/imagick/tree/phpseven Did you compile that with the git head of php-src? I did and stumbled into some problems. ext/standard/php_smart_string_public.h is now almost empty. You should include ext/standard/php_smart_string.h and change some functions: https://github.com/Jan-E/imagick/commit/243c206cf5528255b406a76e1807dd64af209ced Z_BVAL_P does not exist anymore. Possible fix: - convert_to_boolean(multiline); - query_multiline = Z_BVAL_P(multiline); + convert_to_double(multiline); + query_multiline = Z_DVAL_P(multiline); See https://github.com/Jan-E/imagick/commit/c0711521a926ba8fed7b61ae106c6d9039fc71f4 And besides that there were the usual fixes for VC11 and a few deprecated functions. See all my commits at: https://github.com/Jan-E/imagick/commits/phpseven After these commits php_imagick.dll compiled with VC11 and (for Lester) showed itself in phpinfo: https://phpdev.toolsforresearch.com/php-7.0.0-dev-nts-Win32-VC11-x86.htm Complete build: https://phpdev.toolsforresearch.com/php-7.0.0-dev-nts-Win32-VC11-x86.zip Jan