Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81270
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.52 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CA+9eiLs32bFK4GWdOUp+1_HATrwUUbogLDfijhuK5AVQRobjnA@mail.gmail.com>
References: <CAFMT4NqCF6sbpqhg-icd4K_zfOu-RMW=qy6sL-T2YuLH3NQSRg@mail.gmail.com>
	<54C179D8.1050801@pascal-martin.fr>
	<CAFMT4NokF-1Oa5HsWvwZy9R5fHg+jK_OiEEAYFgZOMVRg4mR4A@mail.gmail.com>
	<CAFMT4Np6XGLMDi4A_EPkv0-hR=OYMO1w7z-e5xC3ATLm65Vgeg@mail.gmail.com>
	<CA+9eiLs32bFK4GWdOUp+1_HATrwUUbogLDfijhuK5AVQRobjnA@mail.gmail.com>
Date: Tue, 27 Jan 2015 18:37:10 -0700
Message-ID: <CAFMT4NrQpHtQrEO0jWq+4afS+CptkV71wic24bJF9UW4ndxvcg@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c2c2cef84f09050dac6853
Subject: Re: [PHP-DEV] [RFC][Vote] Return Types
From: levim@php.net (Levi Morrison)

--001a11c2c2cef84f09050dac6853
Content-Type: text/plain; charset=UTF-8

Dmitry,

I updated the patch to latest master and (seem to have) fixed a memory
issue with it. However when I pushed it back up Travis had a lot of failing
return types tests. Could you (and anyone else willing) pull it and see if
you are getting failing tests for release and debug builds?

Cheers,

Levi Morrison


On Tue, Jan 27, 2015 at 1:13 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi Levi,
>
> Do you like me to make final check and merge your pull request?
> We need it :)
>
> Thanks. Dmitry.
>
> On Sat, Jan 24, 2015 at 8:01 AM, Levi Morrison <levim@php.net> wrote:
>
>> On Fri, Jan 23, 2015 at 5:06 PM, Levi Morrison <levim@php.net> wrote:
>> > As a reminder, this RFC (https://wiki.php.net/rfc/return_types) will
>> > close in a few hours. I want to thank everyone who has voted so far,
>> > and encourage anyone who has not yet voted to do so.
>>
>> I have close the voting. It has passed with a vote of 47 to 3.
>>
>> I will update the patch to the latest master and then ping Dmitry to
>> do a final pass before merging it into master.
>>
>
>

--001a11c2c2cef84f09050dac6853--