Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:81197 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96060 invoked from network); 27 Jan 2015 04:10:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Jan 2015 04:10:06 -0000 Authentication-Results: pb1.pair.com header.from=honey@internot.info; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=honey@internot.info; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain internot.info designates 185.57.82.47 as permitted sender) X-PHP-List-Original-Sender: honey@internot.info X-Host-Fingerprint: 185.57.82.47 mail.internot.info Received: from [185.57.82.47] ([185.57.82.47:48160] helo=mail.internot.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 91/42-17708-B9F07C45 for ; Mon, 26 Jan 2015 23:10:04 -0500 Message-ID: <54C70F94.5040000@internot.info> Date: Tue, 27 Jan 2015 15:09:56 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 To: internals@lists.php.net References: <1421309087-9479-1-git-send-email-honey@internot.info> <54C6DE40.30904@internot.info> <54C706B9.3060202@internot.info> In-Reply-To: <54C706B9.3060202@internot.info> OpenPGP: id=296E6003; url=https://internot.info/docs/gpg_pubkey.asc.gpg Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Ie7BDHWPiDkDTfuGhJgUwgMlNJG51BiLi" Subject: Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions. From: honey@internot.info (Joshua Rogers) --Ie7BDHWPiDkDTfuGhJgUwgMlNJG51BiLi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 27/01/15 14:32, Joshua Rogers wrote: > if '1' is returned, the it is OK to continue. > If '0' is returned, it is not OK to continue(return -1) > > > Since this is the case, should the do_fstat function be changed to a > boolean? https://github.com/php/php-src/pull/1031 --=20 -- Joshua Rogers --Ie7BDHWPiDkDTfuGhJgUwgMlNJG51BiLi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUxw+UAAoJEJCcj5QpbmADG6UP/REW4bEej6TXpWZ9lyh28SJI ewc+MdQTotp8kzdqiY4SCOsGwCoHfSzgF10O9qM2GFIIN7TI/mxuI3d5oLZVlSJn SfT+tUV/TF0CHK/hGFKLRJkh24XBZTKm4FWl58fKjDhX+gQTDs1wL82xEFhgBR7h U2IikozZfvr12lyP8YyvBW/qwvuO3QpFiCy4HUs6i5LSzu0yzMEv5YJCLQNEppyG s9j8ryoA5iKW2pNnvRnuZn5k6v3MHFBYqpehMeY5v4ZW2y2gsCU8QdJdwPmitjWM o3TOWZfaRZmOIIfofLWX9C8hYBVl37yhmOozrzZUqzXj2jkKcFi5Vujpv0pEMPba 3jhJopDC6q/Qj/3vTpG1cI6JLNNLcAgGZlZNRztG+IPoDqF0FRBhrVIOZbcBBKMN OmcYQBwJr1uaqwNeMkWLMY54jVq8Wg3jczZC09nGBtUWsaDD6euyfmLHFDGn9ES3 Uxzm4mjNL2CfJ5rH5CPa6/Ch/i7S7OtNSICOrv3SMsEntnYdRGnpXYID4vx22nhw qHrqmMFjaXwMmB0lhM2eMDyLCeNfvvdqJYaA4e6xd9JQH4qAHzyD9ODX0kZPhApH 8lmpTOqfp0f/qzUeI82a4Wa/V/FVcZXOkhB80HXs5OIx+UElHh/S2mqwDpq95H8H VYEpRGHG3p3VhEeT6Oeb =mRms -----END PGP SIGNATURE----- --Ie7BDHWPiDkDTfuGhJgUwgMlNJG51BiLi--