Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81191
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.175 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGa2bXYmwKDAiG_738hCDxt+BpqvhzL1B-DVLK-0gchwYf69Mg@mail.gmail.com>
References: <CAGa2bXYmwKDAiG_738hCDxt+BpqvhzL1B-DVLK-0gchwYf69Mg@mail.gmail.com>
Date: Tue, 27 Jan 2015 11:20:56 +0900
Message-ID: <CAGa2bXY_AFhYcWbAVP0GespOXomni_g-nhWN2L-_L-RM1udOjw@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c1257e114bcc050d98ea77
Subject: Re: Deprecating all INI set/get functions and use ini_set/get()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c1257e114bcc050d98ea77
Content-Type: text/plain; charset=UTF-8

Hi all,

On Sun, Jan 25, 2015 at 9:29 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> I would like to propose INI set/get function deprecation, raise
> E_DEPRECATED,
> and make PHP_INI_MH() use the CODING_STANDARDS.
>
> For example, session module has following INI set/get functions
>
>  - http://php.net/manual/en/function.session-save-path.php
>  - http://php.net/manual/en/function.session-module-name.php
>  - http://php.net/manual/en/function.session-cache-expire.php
>  - http://php.net/manual/en/function.session-cache-limiter.php
>  - http://php.net/manual/en/function.session-name.php
>
> There are 5 PHP functions for session module alone. Some of them include
> runtime check, but
> these checks can be done with PHP_INI_MH() by using state parameter. In
> fact, runtime
> check should be done in PHP_INI_MH() to avoid bugs.
>
> Use of ini_set/get() has following pros and cons
>
> Pros
>  - Less API, hence simpler API.
>  - Modules will be less buggy.
>     i.e. PHP_INI_MH() must handle "state" properly, but it tends to be
> forgotten, 3rd party modules especially.
>  - Consistent coding style/API across modules, both internal and script.
>  - Reduced documentations. INI descriptions are only in INI section.
>  - Less documentations, hence less documentation bugs.
>  - Better documentation. All user needs to know will be in INI section.
>  - Awareness of INI setting use. Users are better to know they are using
> INI. i.e. All INI values has the same limitations,
> INI_SYSTEM/INI_PERDIR/INI_USER, stage limitations if any.
>  - (Please point it out more advantages)
>
> Cons
>  - Existing code modifications. (It's E_DEPRECATED. User may ignore.)
>  - (Please point it out more disadvantages)
>
> Comments are appreciated.
>
> Regards,
>
> P.S. Enum for PHP_INI_MH() "stage" parameter type is better in PHP7. IMO.
>

Since there isn't comment, I guess everyone on this list agree this
proposal.

Shall I start writing this RFC?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c1257e114bcc050d98ea77--