Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81188
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 73025 invoked from network); 27 Jan 2015 01:11:55 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 27 Jan 2015 01:11:55 -0000
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.173 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.216.173 mail-qc0-f173.google.com  
Received: from [209.85.216.173] ([209.85.216.173:48363] helo=mail-qc0-f173.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id CA/98-25415-AD5E6C45 for <internals@lists.php.net>; Mon, 26 Jan 2015 20:11:55 -0500
Received: by mail-qc0-f173.google.com with SMTP id m20so9882165qcx.4
        for <internals@lists.php.net>; Mon, 26 Jan 2015 17:11:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=iuFGPZkz9DPMJyaqIUATSQi5fcwr8IL0sqTVIDlSW68=;
        b=olqkVBhBNxYRx1Awcs97gyPdR41qq+D+WW5hBFXSuxqc3PGhyckEjrBjhNfQvtFuuP
         NCZaMLcwxcuAjIuGPk1bU+YHvlTTBU3ggx7iYu35sUde68iY4nBe3ouQv+8YOLQBAzWv
         tJzY686Djz1zW94ujmUD5XQA0DgNDEKDtYGWeUWTCMaJJvGR/nl/vzCjmt/P5xe6NEvN
         zVDMfJC2tLxn23I9zUiSyjA4U4f1RlmSId7S3cDarmwX7LyQ6YO3r6GasevOwsvfLhF/
         wk7eR1+oit8GfnYuxiwdTtMnbCrXOSySGgkYcC5gSGLqtPZ7qBVaoQdkpG+xUB04Kgh7
         OJhQ==
X-Received: by 10.224.114.209 with SMTP id f17mr2962326qaq.68.1422321111559;
 Mon, 26 Jan 2015 17:11:51 -0800 (PST)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.229.93.70 with HTTP; Mon, 26 Jan 2015 17:11:11 -0800 (PST)
In-Reply-To: <54C6DE40.30904@internot.info>
References: <1421309087-9479-1-git-send-email-honey@internot.info>
 <CAGa2bXbccx5j=hkKrcqBY9gBBY59TQymja-dxuL31=bzUWYw3w@mail.gmail.com> <54C6DE40.30904@internot.info>
Date: Tue, 27 Jan 2015 10:11:11 +0900
X-Google-Sender-Auth: vVD5CBT1z2G9LxBtkUina3CSY0s
Message-ID: <CAGa2bXYtbsdJS-jEX0T0wnvym0HTzR-YKOh2FaKMt3kQGnqjLg@mail.gmail.com>
To: Joshua Rogers <honey@internot.info>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bdc19ac9c73c6050d97f0be
Subject: Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid
 error conditions.
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--047d7bdc19ac9c73c6050d97f0be
Content-Type: text/plain; charset=UTF-8

Hi Joshua,

On Tue, Jan 27, 2015 at 9:39 AM, Joshua Rogers <honey@internot.info> wrote:

> > This patch seems reasonable. Does anyone taking care of this?
> Perhaps it should be
>
> if(do_fstat(data, 1)<0) {
> return -1;
> }
>
> just to conform with the rest of the code


If nobody is taking care of this yet, please send PR or bug report.
Thank you.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--047d7bdc19ac9c73c6050d97f0be--