Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:81187 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 69616 invoked from network); 27 Jan 2015 00:39:35 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Jan 2015 00:39:35 -0000 Authentication-Results: pb1.pair.com header.from=honey@internot.info; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=honey@internot.info; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain internot.info designates 185.57.82.47 as permitted sender) X-PHP-List-Original-Sender: honey@internot.info X-Host-Fingerprint: 185.57.82.47 mail.internot.info Received: from [185.57.82.47] ([185.57.82.47:44930] helo=mail.internot.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 35/08-25415-64ED6C45 for ; Mon, 26 Jan 2015 19:39:34 -0500 Message-ID: <54C6DE40.30904@internot.info> Date: Tue, 27 Jan 2015 11:39:28 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 To: Yasuo Ohgaki CC: "internals@lists.php.net" References: <1421309087-9479-1-git-send-email-honey@internot.info> In-Reply-To: OpenPGP: id=296E6003; url=https://internot.info/docs/gpg_pubkey.asc.gpg Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EBMW8TUVB7vR9moLwabSXc4cOucrDal5i" Subject: Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions. From: honey@internot.info (Joshua Rogers) --EBMW8TUVB7vR9moLwabSXc4cOucrDal5i Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 27/01/15 11:35, Yasuo Ohgaki wrote: > This patch seems reasonable. Does anyone taking care of this? Perhaps it should be if(do_fstat(data, 1)<0) { return -1; } just to conform with the rest of the code --=20 -- Joshua Rogers --EBMW8TUVB7vR9moLwabSXc4cOucrDal5i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUxt5AAAoJEJCcj5QpbmAD/ygP/iofxxL2QCytUQ7xqtbacd9U yEJ9S+WiFnExtgQNmCsJu0Th/XXcrGRI+znB9Kq9me4913fMLnu2a8ckLJRlif4D qJdt+2b2gnN2SjIQGfpDugp3UutBmlO+2e9nKGlBxHsAjeSAbvrq9iiBKqX74p+8 ex1CqRGeUtoIo7QM6E0ctLdUkyCPaMZW+dl45mfAoLsQ7/o44WM5rjlp3ZTNbCL0 lyfW/0xm+ZQ7Iz/tqqczrOIUJrPUc6lVxBJrKEi/SG44lT8zGc8etJuS9Fs4vDSH xgjEA8fZJ5qrS02KGbgMqZLlojcOzW1RNiGh2BqsACoQp/lh4VtiE7EUOzWDM/MJ yjlHIiRWvDKeeT0GArdBQjfSPlcN24FdDcXalUjK3UPLfK2hGFf4qQR0dKAS4VA1 PfceY57PV6BvGyIuePINPqZIsALFN0GEKU+F75t2K46v2BYsZ4X/1LMSMJnkTkwH 4b2+dNWiPw5fTDEsd6cFQ4IeGhskbi5WTfUJ+sd5/QFRpkGs0E5AnuujUhBZADzT ll8XLT2aGwHTnGJ7Td7pl+D9sb5CchYuMJ2e048cwgv1qDmAWghOv2+1taqXZ1Qi 5qztPDGLEU9bel7H13M9hLLw36OaIqt9+kLgBawp62p54IqMXlpwJW62e0A7bXeq nR0F5muR1ReDp9FyF8pF =WmPg -----END PGP SIGNATURE----- --EBMW8TUVB7vR9moLwabSXc4cOucrDal5i--