Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81186
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.182 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <1421309087-9479-1-git-send-email-honey@internot.info>
References: <1421309087-9479-1-git-send-email-honey@internot.info>
Date: Tue, 27 Jan 2015 09:35:57 +0900
Message-ID: <CAGa2bXbccx5j=hkKrcqBY9gBBY59TQymja-dxuL31=bzUWYw3w@mail.gmail.com>
To: Joshua Rogers <honey@internot.info>
Cc: "internals@lists.php.net" <internals@lists.php.net>, Joshua Rogers <git@internot.info>
Content-Type: multipart/alternative; boundary=001a11c22ccca2c0d0050d97728b
Subject: Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid
 error conditions.
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c22ccca2c0d0050d97728b
Content-Type: text/plain; charset=UTF-8

Hi all,

On Thu, Jan 15, 2015 at 5:04 PM, Joshua Rogers <honey@internot.info> wrote:

>  main/streams/plain_wrapper.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/main/streams/plain_wrapper.c b/main/streams/plain_wrapper.c
> index f52383d..72be0b0 100644
> --- a/main/streams/plain_wrapper.c
> +++ b/main/streams/plain_wrapper.c
> @@ -669,7 +669,8 @@ static int php_stdiop_set_option(php_stream *stream,
> int option, int value, void
>                                                 return fd == -1 ?
> PHP_STREAM_OPTION_RETURN_ERR : PHP_STREAM_OPTION_RETURN_OK;
>
>                                         case PHP_STREAM_MMAP_MAP_RANGE:
> -                                               do_fstat(data, 1);
> +                                               if(do_fstat(data, 1)<0)
> +                                                       return -1;
>                                                 if (range->length == 0 &&
> range->offset > 0 && range->offset < data->sb.st_size) {
>                                                         range->length =
> data->sb.st_size - range->offset;
>                                                 }
>

This patch seems reasonable. Does anyone taking care of this?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c22ccca2c0d0050d97728b--