Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81182
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.48 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <54BD5998.4050806@internot.info>
References: <1421694958-14772-1-git-send-email-git@internot.info> <54BD5998.4050806@internot.info>
Date: Tue, 27 Jan 2015 09:25:53 +0900
Message-ID: <CAGa2bXamW__eLOXjTghYhgP2AqDrurXFk9ehL5c3v-x2+sUsXg@mail.gmail.com>
To: Joshua Rogers <honey@internot.info>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bdc19acbbfbea050d974ecc
Subject: Re: [PHP-DEV] [PATCH] Fix potential int overflow in date extension.
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--047d7bdc19acbbfbea050d974ecc
Content-Type: text/plain; charset=UTF-8

Hi all,

On Tue, Jan 20, 2015 at 4:23 AM, Joshua Rogers <honey@internot.info> wrote:

> On 20/01/15 06:15, Joshua Rogers wrote:
> > --
> >  ext/date/lib/tm2unixtime.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> Somebody please take a look at /ext/date/lib/parse_tz.c too:
>
> 438timelib_sll timelib_get_current_offset(timelib_time *t)
> [..]
> 446                        return (t->z + t->dst) * -60;
> Should that be cast timelib_sll too?
>
> I think perhaps the function should be an int, seeing as it looks like
> the result should be negative. Somebody please check.


I'm not familiar with timelib. Anyway, if you could send PR, it would be
nicer.
Or at least a bug report.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--047d7bdc19acbbfbea050d974ecc--