Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81171
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.192.45 as permitted sender)
Message-ID: <54C6933F.9020808@lerdorf.com>
Date: Mon, 26 Jan 2015 11:19:27 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Pascal Chevrel <pascal.chevrel@free.fr>, internals@lists.php.net
References: <A0.00.25415.A2296C45@pb1.pair.com>
In-Reply-To: <A0.00.25415.A2296C45@pb1.pair.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="w2HqHXIjMd68pqgMUSnAKbwr9B8e2WGLM"
Subject: Re: [PHP-DEV] Dort behaviour change on php7 master
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--w2HqHXIjMd68pqgMUSnAKbwr9B8e2WGLM
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable

On 01/26/2015 11:14 AM, Pascal Chevrel wrote:
> Hi all,
>=20
> I just compiled master to test my main application and the good news is=

> that I have no functional regression and some of the views get a
> considerable speed up (like, page generation divided by two!).
>=20
> I had one unit test failing and I reduced that to a simple testcase tha=
t
> I put there:
>=20
> http://3v4l.org/4tGv6
>=20
> Sorting in php master in this specific case is now different on PHP 7
> than on 5.3-5.6 (and actually different than PHP 7 at the beginning of
> the month). The sorting order is now the same as HHVM.
>=20
> I think the HHVM behaviour makes more sense in this case as I don't see=

> why the resulting array should be reversed in this sorting case where
> all lengths are equal, but on the other hand the current behaviour is
> probably 10 years old and maybe it could cause bigger problems in other=

> apps than a unit test to update.
>=20
> Just that you know, in case it matters.

Yeah, this is a known change and the documentation has had a note about
not relying on the ordering of equal elements. Although the note in the
manual is probably a bit too geeky. It should be more explicit and talk
about the effect rather than the cause:

    Note: Like most PHP sorting functions, sort() uses an
          implementation of =BB Quicksort. The pivot is chosen in the
          middle of the partition resulting in an optimal time for
          already sorted arrays. This is however an implementation
          detail you shouldn't rely on.

-Rasmus


--w2HqHXIjMd68pqgMUSnAKbwr9B8e2WGLM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlTGkz8ACgkQlxayKTuqOuCDuACfeSOy6C30+lu3Az/FmLlfWQF/
z8AAn10xa72ggk+Ie8rrK2aueCnkVfq+
=b7gB
-----END PGP SIGNATURE-----

--w2HqHXIjMd68pqgMUSnAKbwr9B8e2WGLM--