Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:81152 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 67175 invoked from network); 26 Jan 2015 08:16:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Jan 2015 08:16:12 -0000 Authentication-Results: pb1.pair.com header.from=php@beccati.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=php@beccati.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.114.167 as permitted sender) X-PHP-List-Original-Sender: php@beccati.com X-Host-Fingerprint: 176.9.114.167 spritz.beccati.com Received: from [176.9.114.167] ([176.9.114.167:51926] helo=mail.beccati.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 82/40-64606-AC7F5C45 for ; Mon, 26 Jan 2015 03:16:11 -0500 Received: (qmail 32121 invoked from network); 26 Jan 2015 08:16:06 -0000 Received: from home.beccati.com (HELO ?192.168.1.202?) (88.149.176.119) by mail.beccati.com with SMTP; 26 Jan 2015 08:16:06 -0000 Message-ID: <54C5F7BB.3060201@beccati.com> Date: Mon, 26 Jan 2015 09:15:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Xinchen Hui , Stanislav Malyshev CC: PHP Internals References: <54C58DAE.2010402@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] PDO & size_t From: php@beccati.com (Matteo Beccati) On 26/01/2015 03:42, Xinchen Hui wrote: > On Mon, Jan 26, 2015 at 8:43 AM, Stanislav Malyshev wrote: >> With recent moving of string lengths to size_t, it looks like PDO APIs >> weren't updated. I.e.: >> >> typedef int (*pdo_stmt_get_col_data_func)(pdo_stmt_t *stmt, int colno, >> char **ptr, zend_ulong *len, int *caller_frees); >> >> This looks like len should be size_t, and in fact fetch_value() in >> pdo_stmt.c sends size_t parameter there, but since I'm not very familiar >> with PDO internals, I'd like to double check - is it an omission and >> will anything break if I change it to size_t? > I think it is okey, of course you should change all related apis in > pdo_* drivers and bump: ext/pdo/php_pdo_driver.h:#define PDO_DRIVER_API 20080721 I guess. Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/