Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81103
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.218.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXbuE=3UG3-1poDvd2+8MLRJ=oeG1tWJiTYOx8D5qCr3Cg@mail.gmail.com>
References: <CAGa2bXZHP3-uHaXJW_QkEva8wECXwu9C3f=v+xGTVodtyCvQKw@mail.gmail.com>
	<54C1D562.1080402@gmail.com>
	<CAGa2bXZwdQeZHTE4G-6YmNPwT4xmjY9nmGTi_yDPse9vVAKm_w@mail.gmail.com>
	<54C1EE77.7040000@gmail.com>
	<CAGa2bXab+YhAw5P8u2YaHAm2+WbSmn5qs1dsMFNsVEwtns2qpg@mail.gmail.com>
	<54C2DE03.6090708@gmail.com>
	<CAGa2bXYOhmZtYqf6dujMq3oyE3Uk3crd9dBj-Qtj2BMrMBRgug@mail.gmail.com>
	<CAPhkiZzGu7bY0TBzGqNeEHsGN0FYWgw_rWtnmFEkkbg2GCLuQQ@mail.gmail.com>
	<CAGa2bXbuE=3UG3-1poDvd2+8MLRJ=oeG1tWJiTYOx8D5qCr3Cg@mail.gmail.com>
Date: Sun, 25 Jan 2015 04:53:30 +0200
Message-ID: <CAPhkiZzf-kpQX4g5xkjAPR6tbP-iCUU6WizMoaQvYSJ3foYHVw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Removing base class from session handler
From: narf@devilix.net (Andrey Andreev)

Hi,

On Sat, Jan 24, 2015 at 7:05 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi Andrey,
>
> On Sat, Jan 24, 2015 at 6:34 PM, Andrey Andreev <narf@devilix.net> wrote:
>>
>> > Let's keep SessionHandler class. However,
>> > PHP_FUNCTION(session_set_save_handler)
>> > should be cleaned up to verify implemented/extended interface/class.
>> > It's
>> > BC.
>> > Do you have opinion for this?
>>
>> php > session_set_save_handler(new stdclass);
>> PHP Warning:  session_set_save_handler() expects parameter 1 to be
>> SessionHandlerInterface, object given in php shell code on line 1
>
>
> As I pasted code in this thread, current code does not check if supplied
> object
> has valid class/interface, but it checks methods implemented. SdtClass does
> not
> have them obviously, therefore it raises error.
>
> It's a legacy code when PHP didn't have proper OOP support. This is the code
> that I'm willing to remove/change.

If I understand correctly, you're suggesting the removal of the
old-style session_set_save_handler() calls where each function is
passed as a separate argument?

That could be a quite significant BC break.

Cheers,
Andrey.