Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81098
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.175 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAPKwhwstZfwE5KuVcVWULeo-fELC_Ef_0KWdpQurW9L4rjqbhg@mail.gmail.com>
References: <CAPKwhwstZfwE5KuVcVWULeo-fELC_Ef_0KWdpQurW9L4rjqbhg@mail.gmail.com>
Date: Sun, 25 Jan 2015 08:33:12 +0900
Message-ID: <CAGa2bXaELC_VN_26RP0OvjuCpnqbPBLp8Wz==F6p-B8iG4SANw@mail.gmail.com>
To: Scott Arciszewski <scott@arciszewski.me>
Cc: "inter >> PHP internals" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bdc19ac832c6e050d6e568b
Subject: Re: [PHP-DEV] Constant-Time Encoding Functions
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--047d7bdc19ac832c6e050d6e568b
Content-Type: text/plain; charset=UTF-8

Hi Scott,

On Fri, Jan 23, 2015 at 12:21 AM, Scott Arciszewski <scott@arciszewski.me>
wrote:

> I've squashed and rebased my pull request that adds a cache-timing-safe
> bin2hex implementation (named ts_bin2hex) to PHP.
>
> https://github.com/php/php-src/pull/909
>
> Before I put more effort into the inverse operation (which, from what I can
> tell, is already constant-time), does anyone have a better naming
> convention suggestion?
>

First of all, I'm +1 for having dedicated API for these functions. i.e. Not
an option for existing functions.
I would rather postfix 'ts'. e.g. bin2hex_ts

The reason why I prefer postfix is PHP functions are named like

'module name' _ 'function name'

ts_*() seems like module function.

Furthermore, should a similar effort be expended for base64
> encoding/decoding functions?
>

base64 is used to encode binary to text commonly. If it can be timing safe,
it would be great!

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--047d7bdc19ac832c6e050d6e568b--