Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81082
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 74450 invoked from network); 24 Jan 2015 17:06:03 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 24 Jan 2015 17:06:03 -0000
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.46 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.216.46 mail-qa0-f46.google.com  
Received: from [209.85.216.46] ([209.85.216.46:57875] helo=mail-qa0-f46.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 83/D3-49997-9F0D3C45 for <internals@lists.php.net>; Sat, 24 Jan 2015 12:06:01 -0500
Received: by mail-qa0-f46.google.com with SMTP id j7so2013777qaq.5
        for <internals@lists.php.net>; Sat, 24 Jan 2015 09:05:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=1cksuIJPMz7exspf92+q/m+UXz0fFMucOEq8VnPmxnY=;
        b=AFJ3e77If5q0ZUKa2s+Pl5+Kq5CU+R3XJfm9CKC1xpNkU5b1JauKbMxdu9dgutu2bn
         4u5Gl57uMRbfvj81VrVPcA4vsphvD5/gfAULT9Ot0yv+hrtJ4AmMzbHdWMX9rDDMcf3U
         T/vhY3eecOcVUuN/7RTpt2w28FF+Ytf2LEj72/WdboDsSD7MfIn0OIZYr479exHiF+Sr
         +umqERdXMplcg+nPzUiaEyapcPPkSbAwgznhkk1AltpCesBojEBC5bo0JYnyeF/0UktI
         b3WJauf5dIfymf7p+CRLWRsC4AZHeebpIPb28MmWBz8GRV8ViUWohBaqNwII+7uT2Yw3
         HJJQ==
X-Received: by 10.140.20.226 with SMTP id 89mr25166042qgj.43.1422119158232;
 Sat, 24 Jan 2015 09:05:58 -0800 (PST)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.229.93.70 with HTTP; Sat, 24 Jan 2015 09:05:18 -0800 (PST)
In-Reply-To: <CAPhkiZzGu7bY0TBzGqNeEHsGN0FYWgw_rWtnmFEkkbg2GCLuQQ@mail.gmail.com>
References: <CAGa2bXZHP3-uHaXJW_QkEva8wECXwu9C3f=v+xGTVodtyCvQKw@mail.gmail.com>
 <54C1D562.1080402@gmail.com> <CAGa2bXZwdQeZHTE4G-6YmNPwT4xmjY9nmGTi_yDPse9vVAKm_w@mail.gmail.com>
 <54C1EE77.7040000@gmail.com> <CAGa2bXab+YhAw5P8u2YaHAm2+WbSmn5qs1dsMFNsVEwtns2qpg@mail.gmail.com>
 <54C2DE03.6090708@gmail.com> <CAGa2bXYOhmZtYqf6dujMq3oyE3Uk3crd9dBj-Qtj2BMrMBRgug@mail.gmail.com>
 <CAPhkiZzGu7bY0TBzGqNeEHsGN0FYWgw_rWtnmFEkkbg2GCLuQQ@mail.gmail.com>
Date: Sun, 25 Jan 2015 02:05:18 +0900
X-Google-Sender-Auth: ignImQX7RltZZikkjpbb-XggdIE
Message-ID: <CAGa2bXbuE=3UG3-1poDvd2+8MLRJ=oeG1tWJiTYOx8D5qCr3Cg@mail.gmail.com>
To: Andrey Andreev <narf@devilix.net>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c1257e4140bb050d68eb84
Subject: Re: [PHP-DEV] Removing base class from session handler
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c1257e4140bb050d68eb84
Content-Type: text/plain; charset=UTF-8

Hi Andrey,

On Sat, Jan 24, 2015 at 6:34 PM, Andrey Andreev <narf@devilix.net> wrote:

> > Let's keep SessionHandler class. However,
> > PHP_FUNCTION(session_set_save_handler)
> > should be cleaned up to verify implemented/extended interface/class. It's
> > BC.
> > Do you have opinion for this?
>
> php > session_set_save_handler(new stdclass);
> PHP Warning:  session_set_save_handler() expects parameter 1 to be
> SessionHandlerInterface, object given in php shell code on line 1


As I pasted code in this thread, current code does not check if supplied
object
has valid class/interface, but it checks methods implemented. SdtClass does
not
have them obviously, therefore it raises error.

It's a legacy code when PHP didn't have proper OOP support. This is the code
that I'm willing to remove/change.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c1257e4140bb050d68eb84--