Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81072
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.218.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYOhmZtYqf6dujMq3oyE3Uk3crd9dBj-Qtj2BMrMBRgug@mail.gmail.com>
References: <CAGa2bXZHP3-uHaXJW_QkEva8wECXwu9C3f=v+xGTVodtyCvQKw@mail.gmail.com>
	<54C1D562.1080402@gmail.com>
	<CAGa2bXZwdQeZHTE4G-6YmNPwT4xmjY9nmGTi_yDPse9vVAKm_w@mail.gmail.com>
	<54C1EE77.7040000@gmail.com>
	<CAGa2bXab+YhAw5P8u2YaHAm2+WbSmn5qs1dsMFNsVEwtns2qpg@mail.gmail.com>
	<54C2DE03.6090708@gmail.com>
	<CAGa2bXYOhmZtYqf6dujMq3oyE3Uk3crd9dBj-Qtj2BMrMBRgug@mail.gmail.com>
Date: Sat, 24 Jan 2015 11:34:42 +0200
Message-ID: <CAPhkiZzGu7bY0TBzGqNeEHsGN0FYWgw_rWtnmFEkkbg2GCLuQQ@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Removing base class from session handler
From: narf@devilix.net (Andrey Andreev)

Hi,



On Sat, Jan 24, 2015 at 2:24 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi Stas,
>
> On Sat, Jan 24, 2015 at 8:49 AM, Stanislav Malyshev <smalyshev@gmail.com>
> wrote:
>
>> > This is the only reasonable use I know. I would to write user
>> > serializer(read/writer)
>> > handler for it.
>>
>> So we went from no reasonable use to one reasonable use, documented at
>> the manual. I think it is also reasonable to suppose there are more uses
>> for it.
>>
>
> This is because session module lacks user defined serializer. Save handler
> handles session data storage. Serialize handler handles how data is
> converted/represented. IMHO.
>

That's not the only use case.

Some time ago I proposed a session.match_ip feature and argued that if
I wanted to implement it in userland code, I'd have to implement the
*whole* session handler from scratch. An example using the
SessionHandler class proved me wrong in that regard.

Surely, people are using it for other stuff as well and it's not about
the serializer.

> I would like to make SessionHandler deprecated, encourage user serialize
> handler for new PHP because it's more efficient and clean. Do you agree?
>

How can it possibly be more efficient and clean if you have to
re-implement everything with user-level code?

> Let's keep SessionHandler class. However,
> PHP_FUNCTION(session_set_save_handler)
> should be cleaned up to verify implemented/extended interface/class. It's
> BC.
> Do you have opinion for this?

php > session_set_save_handler(new stdclass);
PHP Warning:  session_set_save_handler() expects parameter 1 to be
SessionHandlerInterface, object given in php shell code on line 1

Cheers,
Andrey.