Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:81064 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 12451 invoked from network); 24 Jan 2015 02:15:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jan 2015 02:15:18 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.52 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.192.52 mail-qg0-f52.google.com Received: from [209.85.192.52] ([209.85.192.52:57923] helo=mail-qg0-f52.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 01/10-10645-53003C45 for ; Fri, 23 Jan 2015 21:15:17 -0500 Received: by mail-qg0-f52.google.com with SMTP id z107so530353qgd.11 for ; Fri, 23 Jan 2015 18:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=JoFxW/K65m8pyW4yufrsc3ALfO/4ZTChQ3L7oOY+UTY=; b=hJ2nWU1Nkf/LP3FpNbNN3z3IYSNfwnBMKBMGcnjJjvrpY9oZB2nCXvD09pCItjAn9l eydJAlGpa0acEpEcfK2urU8vyIb6KugqD2wWftA4JstOTlBQwVxTY74RlfLU/LdhjY2A bZdmx8IpV0cEfu8JDvJHHNgML0W6DdtSwnMJ9kfrmuVbH42a8Ji/JAlv0oUWqN4pjoXz dISsiGrlC8Ty5LR/y3fL4p6YGQGXm86aAjpNjAlQ23xNbG4JgDJF90FAnHynV6WA2gfr N8tOHcownejMefcq3xtTSK+gmhNe6vRhYpbIhrQ3gp/qObm+/HrAf3J9RsmSDEL7CA6/ 0qrw== X-Received: by 10.224.114.209 with SMTP id f17mr1429242qaq.68.1422065714338; Fri, 23 Jan 2015 18:15:14 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.229.93.70 with HTTP; Fri, 23 Jan 2015 18:14:34 -0800 (PST) In-Reply-To: <54C2E76F.8090602@gmail.com> References: <54C1D562.1080402@gmail.com> <54C1EE77.7040000@gmail.com> <54C2DE03.6090708@gmail.com> <54C2E76F.8090602@gmail.com> Date: Sat, 24 Jan 2015 11:14:34 +0900 X-Google-Sender-Auth: jv5QIgBDr-Zkp1dwDCL5c0u0cTM Message-ID: To: Stanislav Malyshev Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=047d7bdc19acc0248a050d5c79f4 Subject: Re: [PHP-DEV] Removing base class from session handler From: yohgaki@ohgaki.net (Yasuo Ohgaki) --047d7bdc19acc0248a050d5c79f4 Content-Type: text/plain; charset=UTF-8 Hi Stas, On Sat, Jan 24, 2015 at 9:29 AM, Stanislav Malyshev wrote: > > Let's keep SessionHandler class. However, > > PHP_FUNCTION(session_set_save_handler) > > should be cleaned up to verify implemented/extended interface/class. > > It's BC. > > Do you have opinion for this? > > I think it would be OK to require implementing the interface (and of > course the class should be implementing that as well). That sounds to me > like a kind of BC break that is acceptable in PHP 7. Probably requires > an RFC though as it is a BC break - and maybe there are reasons why it > wasn't done that I was missing, then they will be exposed when > discussing the RFC. I don't remember well the reason why neither. I guess the reason why session_set_save_handler() does not check class/interface definition as usual is for PHP4 compatibility. It's legacy code anyway. I'll write the RFC as soon as other proposal discussion finishes. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --047d7bdc19acc0248a050d5c79f4--