Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81063
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.173 as permitted sender)
Message-ID: <54C2E76F.8090602@gmail.com>
Date: Fri, 23 Jan 2015 16:29:35 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
CC: "internals@lists.php.net" <internals@lists.php.net>
References: <CAGa2bXZHP3-uHaXJW_QkEva8wECXwu9C3f=v+xGTVodtyCvQKw@mail.gmail.com> <54C1D562.1080402@gmail.com> <CAGa2bXZwdQeZHTE4G-6YmNPwT4xmjY9nmGTi_yDPse9vVAKm_w@mail.gmail.com> <54C1EE77.7040000@gmail.com> <CAGa2bXab+YhAw5P8u2YaHAm2+WbSmn5qs1dsMFNsVEwtns2qpg@mail.gmail.com> <54C2DE03.6090708@gmail.com> <CAGa2bXYOhmZtYqf6dujMq3oyE3Uk3crd9dBj-Qtj2BMrMBRgug@mail.gmail.com>
In-Reply-To: <CAGa2bXYOhmZtYqf6dujMq3oyE3Uk3crd9dBj-Qtj2BMrMBRgug@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Removing base class from session handler
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Let's keep SessionHandler class. However,
> PHP_FUNCTION(session_set_save_handler)
> should be cleaned up to verify implemented/extended interface/class.
> It's BC.
> Do you have opinion for this?

I think it would be OK to require implementing the interface (and of
course the class should be implementing that as well). That sounds to me
like a kind of BC break that is acceptable in PHP 7. Probably requires
an RFC though as it is a BC break - and maybe there are reasons why it
wasn't done that I was missing, then they will be exposed when
discussing the RFC.

-- 
Stas Malyshev
smalyshev@gmail.com