Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:8106 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14647 invoked by uid 1010); 24 Feb 2004 22:10:57 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 14623 invoked from network); 24 Feb 2004 22:10:57 -0000 Received: from unknown (HELO lt1.firehawksystems.com) (64.71.143.247) by pb1.pair.com with SMTP; 24 Feb 2004 22:10:57 -0000 Received: from [10.0.0.2] (pcp955202pcs.bechgr01.in.comcast.net [68.57.213.101]) (authenticated bits=0) by lt1.firehawksystems.com (8.12.10/8.12.10) with ESMTP id i1OMAt2W025314 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO) for ; Tue, 24 Feb 2004 14:10:56 -0800 Mime-Version: 1.0 (Apple Message framework v612) Content-Transfer-Encoding: 7bit Message-ID: <4E85B26A-6716-11D8-B780-003065F88EBA@firehawksystems.com> Content-Type: text/plain; charset=US-ASCII; format=flowed To: internals@lists.php.net Date: Tue, 24 Feb 2004 17:10:51 -0500 X-Mailer: Apple Mail (2.612) Subject: Patch now or wait From: list@firehawksystems.com ("Brian J. France") I have already run this past Sterling, but figured I would make sure there are no other objections to applying this patch to both 4.3 and HEAD. It allows switching back to the standard output by calling: curl_setopt($ch, CURLOPT_RETURNTRANSFER, 0); Thanks, Brian ---- Based on 4.3.4 source --- --- ext/curl/curl.c.orig Fri Feb 20 13:35:39 2004 +++ ext/curl/curl.c Fri Feb 20 13:37:15 2004 @@ -803,6 +809,9 @@ if (Z_LVAL_PP(zvalue)) { ch->handlers->write->method = PHP_CURL_RETURN; } + else { + ch->handlers->write->method = PHP_CURL_STDOUT; + } break; case CURLOPT_BINARYTRANSFER: convert_to_long_ex(zvalue);