Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81025
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.51 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <54C1D562.1080402@gmail.com>
References: <CAGa2bXZHP3-uHaXJW_QkEva8wECXwu9C3f=v+xGTVodtyCvQKw@mail.gmail.com>
 <54C1D562.1080402@gmail.com>
Date: Fri, 23 Jan 2015 15:29:20 +0900
Message-ID: <CAGa2bXZwdQeZHTE4G-6YmNPwT4xmjY9nmGTi_yDPse9vVAKm_w@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11337bfc0662fe050d4beb42
Subject: Re: [PHP-DEV] Removing base class from session handler
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11337bfc0662fe050d4beb42
Content-Type: text/plain; charset=UTF-8

Hi Stas,

On Fri, Jan 23, 2015 at 2:00 PM, Stanislav Malyshev <smalyshev@gmail.com>
wrote:

> > User script must have access the struct(PS(mod_data)) to extend base
> class.
>
> Can't I extend the base class and then do something in overriding
> methods and call parent, or override some methods but not others and
> thus have the original methods still work just fine?
>

User may extend SessionHandler class like

class MySession extends SessionHandler {}

but user cannot extend base class(SessionHandler) capability because user
script
cannot access to PS(mod_data).

Better way to define user defined session class is to use
SessionHandlerInterface*.
I would like to discuss interface cleanup, but in different thread.


>
> > In conclusion, SessionHandler object has no real use except as a toy and
> > makes session module complex unnecessary. Since it cannot have real use,
> > nobody is using it. Therefore, I would like to remove it.
>
> I'm not sure, what you actually are proposing to remove? I'm not sure
> how you can "remove an object". Could you explain further?


I should have written "remove the SessionHandler class". As I wrote, user
may
extend SessionHandler class.

However, defining user session class as
class MySession extends SessionHandler {}
have no merit. Users must implement required methods to be useful.
Interface is there for this purpose.

I would like to remove SessionHandler class, but I don't object to have
empty
SessionHandler class for maximum compatibility.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11337bfc0662fe050d4beb42--