Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:81006
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.216.171 as permitted sender)
Message-ID: <54C193A6.7060206@lerdorf.com>
Date: Thu, 22 Jan 2015 16:19:50 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Dan Ackroyd <danack@basereality.com>
CC: "internals@lists.php.net" <internals@lists.php.net>
References: <54C12DD8.7020800@lerdorf.com>	<54C16698.4080203@lsces.co.uk> <CA+kxMuRC-pdZ9k4p00ZysjC2o2xHR3hYvOVoLOX-j_0r_ZBR_Q@mail.gmail.com>
In-Reply-To: <CA+kxMuRC-pdZ9k4p00ZysjC2o2xHR3hYvOVoLOX-j_0r_ZBR_Q@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="ijEbVLimWd1FwDIG60GFEIrgEUIKUCmVd"
Subject: Re: [PHP-DEV] PHP7 Homework for everyone reading this list
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--ijEbVLimWd1FwDIG60GFEIrgEUIKUCmVd
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/22/2015 02:30 PM, Dan Ackroyd wrote:
> On 22 January 2015 at 21:07, Lester Caine <lester@lsces.co.uk> wrote:
>> imagick is now available?
>=20
> Not yet. I'll try to finish it off before the end of the weekend. Most
> of the work was done earlier, but I need to add the changes for the
> Native TLS.
>=20
> btw this request to update the PHPNG upgrading guide is still open:
>=20
>> Thanks. I think the TSRM changes need to be added, which could be copi=
ed from:
>> https://github.com/php/php-src/commit/dec8eb431adee340fb8dfb9ff33ed29d=
3279c35f
>> Providing a link to a commit that implemented the TSRM changes for an
>> extension, so that people could see the actual changes needed, would
>> be awesome.

For most extensions that just do something simple like imagick does:

#ifdef ZTS
# define IMAGICK_G(v) TSRMG(imagick_globals_id, zend_imagick_globals *, v=
)
#else
# define IMAGICK_G(v) (imagick_globals.v)
#endif

There is absolutely nothing to do. You can, just for your own amusement
and because it makes the code look prettier, go through and remove all
instances of TSRMLS_* macros in all your C files. But it isn't critical
since they are just defined to nothing in PHP7. Just leave that TSRMG
define in your .h file and it will do the right thing.

-Rasmus


--ijEbVLimWd1FwDIG60GFEIrgEUIKUCmVd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlTBk6YACgkQlxayKTuqOuCM0QCcCe5nwGw293os9LYOe/gZyk08
dlQAni5S8CweWFrTaNymvymo6L0nHA5Y
=dveT
-----END PGP SIGNATURE-----

--ijEbVLimWd1FwDIG60GFEIrgEUIKUCmVd--