Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80990
Return-Path: <smalyshev@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 57316 invoked from network); 22 Jan 2015 20:34:18 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 22 Jan 2015 20:34:18 -0000
Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.48 as permitted sender)
X-PHP-List-Original-Sender: smalyshev@gmail.com
X-Host-Fingerprint: 209.85.220.48 mail-pa0-f48.google.com  
Received: from [209.85.220.48] ([209.85.220.48:55794] helo=mail-pa0-f48.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 43/BF-61273-9CE51C45 for <internals@lists.php.net>; Thu, 22 Jan 2015 15:34:17 -0500
Received: by mail-pa0-f48.google.com with SMTP id ey11so4059436pad.7
        for <internals@lists.php.net>; Thu, 22 Jan 2015 12:34:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        bh=5/rnY7pEJXSoMmlMalkLBG/spdpRA1wzKCPB1WySpyI=;
        b=M/Xl8TQN/sKtYlcY5kowZHaL/SLFAAwQwPB5I6LK8IEHGPKeV6R11BT7wG4dFhl3L1
         9xdVKeGozG6YdcfK3nB0V7W7U3gO7NfepMN9hWnUEOfmjN2jkdzDBbR11dxH7R0XvGBA
         RDa3uDqngf8kdaK8Rapa2MpeUbuP1SkBev4Hz+zIPs4l38AMbNEBTvRqUa4bJAriX9Ak
         KJZpQ9sks8p502eDz9N0pSruKzibTRh5QFB5c2Krw4TSBQmL5gjhR+YlHcZJhAHKP/EQ
         8w/o146gFmhxyXBAVSBypfyXtnGoLDK1zsrK0vk7IuDUFvMqFT/rAd+aU3wpCxYsjul3
         xA7g==
X-Received: by 10.66.141.109 with SMTP id rn13mr5110438pab.113.1421958854710;
        Thu, 22 Jan 2015 12:34:14 -0800 (PST)
Received: from Stas-Air.local ([208.66.31.10])
        by mx.google.com with ESMTPSA id id1sm9742367pbc.80.2015.01.22.12.34.13
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Thu, 22 Jan 2015 12:34:14 -0800 (PST)
Message-ID: <54C15EC4.3060905@gmail.com>
Date: Thu, 22 Jan 2015 12:34:12 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Yasuo Ohgaki <yohgaki@ohgaki.net>, 
 Rasmus Lerdorf <rasmus@lerdorf.com>
CC: PHP internals <internals@lists.php.net>
References: <54BECE9E.5050502@lerdorf.com> <54BED307.5010606@lerdorf.com> <54BEDABB.2040406@gmail.com> <54BEE31B.3020403@lerdorf.com> <CAGa2bXYzvjaZ=ORK9WCdVfSfWzOLddh2TrAViqj8X0n31V9wNQ@mail.gmail.com>
In-Reply-To: <CAGa2bXYzvjaZ=ORK9WCdVfSfWzOLddh2TrAViqj8X0n31V9wNQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: Help - gcc mystery in ext/imap
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Should we use size_t/ptrdiff_t everywhere applicable? 

We should use it everywhere where we deal with zend_string and such -
i.e. where the size_t parameter is expected. If it's related to outside
library - we should use its type and check (e.g. ICU uses int32_t). For
internal things, I guess it goes on case-by-case basis, depending on how
big the thing in question can get.

-- 
Stas Malyshev
smalyshev@gmail.com