Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80984 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 41519 invoked from network); 22 Jan 2015 18:39:48 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Jan 2015 18:39:48 -0000 Authentication-Results: pb1.pair.com header.from=php@beccati.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=php@beccati.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.114.167 as permitted sender) X-PHP-List-Original-Sender: php@beccati.com X-Host-Fingerprint: 176.9.114.167 spritz.beccati.com Received: from [176.9.114.167] ([176.9.114.167:38907] helo=mail.beccati.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9C/EC-61273-2F341C45 for ; Thu, 22 Jan 2015 13:39:47 -0500 Received: (qmail 25448 invoked from network); 22 Jan 2015 18:39:42 -0000 Received: from home.beccati.com (HELO ?192.168.1.202?) (88.149.176.119) by mail.beccati.com with SMTP; 22 Jan 2015 18:39:42 -0000 Message-ID: <54C143E0.4030301@beccati.com> Date: Thu, 22 Jan 2015 19:39:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Levi Morrison CC: internals , Dmitry Stogov , Sebastian Bergmann References: <54C12DD8.7020800@lerdorf.com> <54C1352A.3030805@php.net> <54C13BB9.5090908@beccati.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] PHP7 Homework for everyone reading this list From: php@beccati.com (Matteo Beccati) On 22/01/2015 19:32, Levi Morrison wrote: >> I had to quarantine a couple of tests in Doctrine and PHPUnit as they both >> depend on the re-usage of the hashes returned by spl_object_hash(), which >> shouldn't actually be depended upon (am I right dmitry?). > > I'm not Dmitry, but I am fairly certain you should not rely on hashes > being reused. I was quoting a quick discussion we had, that's why I mentioned him ;) To make my stament clearer, I meant "spl_object_hash re-using the hash of an object that has been unset and garbage collected". TBH I don't recall what the PHPUnit test does, but I'm fairly sure that the Doctrine2 tests uses such test to verify that there are no "leaks" using a certain recommended pattern for batch operations (or something along the lines). Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/