Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80976
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.182 as permitted sender)
MIME-Version: 1.0
Sender: reeze.xia@gmail.com
In-Reply-To: <CAGa2bXZGUXMADYA=n9P2MA6LzqJ8XXnHsa+eo9j_gaHQrkiuDw@mail.gmail.com>
References: <20150121043939.5129B26183A@dd15934.kasserver.com> <CAGa2bXZGUXMADYA=n9P2MA6LzqJ8XXnHsa+eo9j_gaHQrkiuDw@mail.gmail.com>
Date: Fri, 23 Jan 2015 00:01:27 +0800
Message-ID: <CAG1choqHKEgdB26VWFb4QiqtgOq7XM0_ZdSwDsFTzPxVOVXucQ@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Thomas Bley <mails@thomasbley.de>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b62494210fb91050d3fca86
Subject: Re: [PHP-DEV] Enable error_handler callback parameters to be passed
 by reference
From: reeze@php.net (reeze)

--047d7b62494210fb91050d3fca86
Content-Type: text/plain; charset=ISO-8859-1

I like the idea, we have the similar scenario, we need to print request log
id to the log,

so I just made a PR to implement this:
https://github.com/php/php-src/pull/1018  the PR is against master,
but I think this could also been in 5.5.

On 22 January 2015 at 18:41, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Thomas,
>
> On Wed, Jan 21, 2015 at 1:39 PM, Thomas Bley <mails@thomasbley.de> wrote:
>
> > In userland it is sometimes necessary to extend PHP's notices/warnings
> > with additional information (e.g. username from session, stack trace,
> etc.)
> > I'm proposing to enable error_handler callback parameters to be passed by
> > reference to be able to append additional data to error messages.
> >
> > Example:
> >
> > <?php
> > ini_set('error_reporting', E_ALL);
> > ini_set('display_errors', 0);
> > ini_set('log_errors', 1);
> > ini_set('error_log', 'php_error.log');
> >
> > function myErrorHandler($errno, &$errstr, $errfile, $errline) {
> >   if (!empty($_SESSION['username'])) {
> >     $errstr .= ', username: '.$_SESSION['username'];
> >   }
> >   return false; // continue normal error handler
> > }
> >
> > set_error_handler("myErrorHandler");
> >
> > function test() {
> >   echo tests; // Use of undefined constant tests
> > }
> >
> > test();
> >
> > Gives in php_error.log:
> > [21-Jan-2015 04:32:26 UTC] PHP Notice:  Use of undefined constant tests -
> > assumed 'tests', username: ... in error.php on line 17
> >
> > Instead of:
> > [21-Jan-2015 04:32:26 UTC] PHP Notice:  Use of undefined constant tests -
> > assumed 'tests' in error.php on line 17
> >
>
> This would be very useful for accounting!
> If you cannot send pull requests, please file this to bugs.php.net as
> request.
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>

--047d7b62494210fb91050d3fca86--