Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80970
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.173 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <20150121043939.5129B26183A@dd15934.kasserver.com>
References: <20150121043939.5129B26183A@dd15934.kasserver.com>
Date: Thu, 22 Jan 2015 19:41:46 +0900
Message-ID: <CAGa2bXZGUXMADYA=n9P2MA6LzqJ8XXnHsa+eo9j_gaHQrkiuDw@mail.gmail.com>
To: Thomas Bley <mails@thomasbley.de>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c11a98f913d7050d3b5332
Subject: Re: [PHP-DEV] Enable error_handler callback parameters to be passed
 by reference
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c11a98f913d7050d3b5332
Content-Type: text/plain; charset=UTF-8

Hi Thomas,

On Wed, Jan 21, 2015 at 1:39 PM, Thomas Bley <mails@thomasbley.de> wrote:

> In userland it is sometimes necessary to extend PHP's notices/warnings
> with additional information (e.g. username from session, stack trace, etc.)
> I'm proposing to enable error_handler callback parameters to be passed by
> reference to be able to append additional data to error messages.
>
> Example:
>
> <?php
> ini_set('error_reporting', E_ALL);
> ini_set('display_errors', 0);
> ini_set('log_errors', 1);
> ini_set('error_log', 'php_error.log');
>
> function myErrorHandler($errno, &$errstr, $errfile, $errline) {
>   if (!empty($_SESSION['username'])) {
>     $errstr .= ', username: '.$_SESSION['username'];
>   }
>   return false; // continue normal error handler
> }
>
> set_error_handler("myErrorHandler");
>
> function test() {
>   echo tests; // Use of undefined constant tests
> }
>
> test();
>
> Gives in php_error.log:
> [21-Jan-2015 04:32:26 UTC] PHP Notice:  Use of undefined constant tests -
> assumed 'tests', username: ... in error.php on line 17
>
> Instead of:
> [21-Jan-2015 04:32:26 UTC] PHP Notice:  Use of undefined constant tests -
> assumed 'tests' in error.php on line 17
>

This would be very useful for accounting!
If you cannot send pull requests, please file this to bugs.php.net as
request.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c11a98f913d7050d3b5332--