Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80966 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87328 invoked from network); 22 Jan 2015 10:09:38 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Jan 2015 10:09:38 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.42 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.192.42 mail-qg0-f42.google.com Received: from [209.85.192.42] ([209.85.192.42:64576] helo=mail-qg0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 48/94-61273-16CC0C45 for ; Thu, 22 Jan 2015 05:09:37 -0500 Received: by mail-qg0-f42.google.com with SMTP id q107so439144qgd.1 for ; Thu, 22 Jan 2015 02:09:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=C1DAlWlMyJPnAzV+GaOHoVaXccts5WMun6WqzDSlGQc=; b=05b+omlnrXmh0Ui4bXRHSuMkhS9e6nOLbCwPr3XaickYvGMqGkztRErgw7Dae1zQqi cybgAbhHNGJR8+xiwwlzaUrMi1y2DDyGhVRazjZ2dK6hLFuXodk0vAigPClamvwSlC/Q ANS2uQTOtBcHJnd07UL2cx064tIatWgzGSqD0QdRa6jWblNyH18Ql+kHuJrWKM9CaNq0 79lOYy80KnEVRGCncrXAfQicf0GdaebeT2lpXfbYa8hwZCi3fo2I2LPWfdc9MzHMsRNQ 6SEx2DJ98Yk4eGcQ23wjiCn+w1VY5+w5HuVx8BBg1Pdx87MqCr1QWzqBeUThfaw3WinP t1Pg== MIME-Version: 1.0 X-Received: by 10.229.59.69 with SMTP id k5mr1030328qch.14.1421921374390; Thu, 22 Jan 2015 02:09:34 -0800 (PST) Received: by 10.140.22.106 with HTTP; Thu, 22 Jan 2015 02:09:34 -0800 (PST) In-Reply-To: References: Date: Thu, 22 Jan 2015 11:09:34 +0100 Message-ID: To: Nikita Popov Cc: Sara Golemon , PHP internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] ZEND_APIifying zendparse() From: pierre.php@gmail.com (Pierre Joye) On Thu, Jan 22, 2015 at 11:00 AM, Nikita Popov wrote: > On Thu, Jan 22, 2015 at 10:28 AM, Sara Golemon wrote: > >> http://github.com/sgolemon/astkit (See the README.md) >> >> I'm using zendparse() to generate an AST but *not* compile it to >> bytecode. In order to get this extension building, I have to patch >> php-src to export the zendparse symbol. Anyone object to me pushing >> that change? >> >> diff --git a/Zend/zend_globals_macros.h b/Zend/zend_globals_macros.h >> index b8fb763..190905f 100644 >> --- a/Zend/zend_globals_macros.h >> +++ b/Zend/zend_globals_macros.h >> @@ -36,7 +36,7 @@ BEGIN_EXTERN_C() >> # define CG(v) (compiler_globals.v) >> extern ZEND_API struct _zend_compiler_globals compiler_globals; >> #endif >> -int zendparse(void); >> +ZEND_API int zendparse(void); >> >> >> /* Executor */ >> > > Looks reasonable :) Indeed. Add a note in UPGRADING.INTERNALS while being at it pls :) -- Pierre @pierrejoye | http://www.libgd.org