Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80965 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 85498 invoked from network); 22 Jan 2015 10:00:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Jan 2015 10:00:33 -0000 Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.52 as permitted sender) X-PHP-List-Original-Sender: nikita.ppv@gmail.com X-Host-Fingerprint: 74.125.82.52 mail-wg0-f52.google.com Received: from [74.125.82.52] ([74.125.82.52:61978] helo=mail-wg0-f52.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F8/34-61273-B3AC0C45 for ; Thu, 22 Jan 2015 05:00:30 -0500 Received: by mail-wg0-f52.google.com with SMTP id y19so698188wgg.11 for ; Thu, 22 Jan 2015 02:00:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=YcoXY9kLhRr/9Z4UaAvRMzJ1hfdqU0zzRjNR5LRrrys=; b=eCgOcU5qjkqWygmLYkilyu7WiIBrBW6kNS6b/Bb8MSCYXRWbxlTYUUG1qKIHnzendz JQrJ09Tv+0tDeCVd3JSH94jpoJMdA5RbXjUM2Z/pAEPc+C4yP0YY1hbZtT4YOqZpKyJb G+UgKCwQU6uaX8qWXBZAJp17K/lfTKaVdHw99FFG60YxCqV06voYRzYa6TROd7KkVBb6 aJUsDxM4ri09Z4k6tQX96g9BATzsTTFY1yo7/PsIvi7hxKUSl5/e9Fu7wMJRvdjU7ZHQ J7wGQJEhGCNBUC9pcgQyNT6mVCO0Eb3Dk4cKru8NRjZoarMISPU9KmpqrJpAIy2yfywV eUkg== MIME-Version: 1.0 X-Received: by 10.194.95.10 with SMTP id dg10mr1316211wjb.82.1421920822050; Thu, 22 Jan 2015 02:00:22 -0800 (PST) Received: by 10.27.10.138 with HTTP; Thu, 22 Jan 2015 02:00:22 -0800 (PST) In-Reply-To: References: Date: Thu, 22 Jan 2015 11:00:22 +0100 Message-ID: To: Sara Golemon Cc: PHP internals Content-Type: multipart/alternative; boundary=047d7bdc80787f465b050d3abd74 Subject: Re: [PHP-DEV] ZEND_APIifying zendparse() From: nikita.ppv@gmail.com (Nikita Popov) --047d7bdc80787f465b050d3abd74 Content-Type: text/plain; charset=UTF-8 On Thu, Jan 22, 2015 at 10:28 AM, Sara Golemon wrote: > http://github.com/sgolemon/astkit (See the README.md) > > I'm using zendparse() to generate an AST but *not* compile it to > bytecode. In order to get this extension building, I have to patch > php-src to export the zendparse symbol. Anyone object to me pushing > that change? > > diff --git a/Zend/zend_globals_macros.h b/Zend/zend_globals_macros.h > index b8fb763..190905f 100644 > --- a/Zend/zend_globals_macros.h > +++ b/Zend/zend_globals_macros.h > @@ -36,7 +36,7 @@ BEGIN_EXTERN_C() > # define CG(v) (compiler_globals.v) > extern ZEND_API struct _zend_compiler_globals compiler_globals; > #endif > -int zendparse(void); > +ZEND_API int zendparse(void); > > > /* Executor */ > Looks reasonable :) Nikita --047d7bdc80787f465b050d3abd74--