Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80951 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 49456 invoked from network); 22 Jan 2015 05:06:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Jan 2015 05:06:41 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.179 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.216.179 mail-qc0-f179.google.com Received: from [209.85.216.179] ([209.85.216.179:50204] helo=mail-qc0-f179.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 68/70-44026-F5580C45 for ; Thu, 22 Jan 2015 00:06:41 -0500 Received: by mail-qc0-f179.google.com with SMTP id w7so19342637qcr.10 for ; Wed, 21 Jan 2015 21:06:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=hYhKa/rtSpLglojaAroBfhu5D2o5Auzqo9T5834/UOI=; b=co0MhHhtmKr6Nl1p4HukYrpymnzdxoCGAz+6fOhZm9mqgHVoy6cxm1HgVPcn2KZcXF 4FuUH59+YXXHlQ7j/U0e34/FKIx9DxUogQk9O/UeSNqta4W+FOrFQoGR5G4ndI0sYZa3 iRRjK5Lr7HAM42LrebL/Ns4iltu4q9IXsXzaqV+CevKEHefs1TF3Qrt9SMbZmCGMDMbU nqPtd/qR9xCe4A5cVfmvwYpgkqU/yQo/GkD6N89uYpP+wP0vW/hFnJjjGAZAwFU4+wpS AqkJT609khufHGFik9dXxk8/Ae2bNq8xGhbXk8M1EMKwWFgcwyPfVosizUC2l8ZNP4BM aS7w== X-Received: by 10.140.21.229 with SMTP id 92mr61603116qgl.33.1421903197092; Wed, 21 Jan 2015 21:06:37 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.229.93.70 with HTTP; Wed, 21 Jan 2015 21:05:56 -0800 (PST) In-Reply-To: References: Date: Thu, 22 Jan 2015 14:05:56 +0900 X-Google-Sender-Auth: Bc1G0_d0Ck8UZ2pkokmrfjfxTEg Message-ID: To: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a11c12f8cf7c2c6050d36a220 Subject: Re: [PHP-DEV] [VOTE] RFC: Introduce session_start() options - read_only, unsafe_lock, lazy_write and lazy_destroy From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a11c12f8cf7c2c6050d36a220 Content-Type: text/plain; charset=UTF-8 Hi all, On Sun, Mar 16, 2014 at 3:11 PM, Yasuo Ohgaki wrote: > Modified patch for this RFC is here > > https://github.com/yohgaki/php-src/compare/PHP-5.6-rfc-session-lock > > There may be leftover still. I'll check it again later, but it's > appreciated if you find any. > > Someone asked if I'm going to allow to change all of session INIs by > session_start(), > I think it's good to have. > > I would like to implement this as hash of INI options and handlers like > > "option_name" => function_of_INI_modify_handler; > > This way, I can iterate parameter array easily/efficiently, can change INI > values > easily/efficiently and raise appropriate errors. > > Any comments for this? > Sorry that the patch didn't included in PHP 5.6. I've made patch for master since PHP 5.6 is released already. https://wiki.php.net/rfc/session-lock-ini https://github.com/php/php-src/pull/1016 Except comments, changes are almost minimal, but includes a few bug fixes that tests equality of PS(session_status) against "php_session_none". The comparison must be "PS(session_status) != php_session_active" as it has php_session_disabled. I also removed 2 needless session globals. Comments are appreciated. This patch boosts PHP application performance a lot when session data have not changed. It's faster than benchmark in the wiki because hashing has removed. If I don't any comment in a few days, I'll merge it to master. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a11c12f8cf7c2c6050d36a220--