Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80948 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 36395 invoked from network); 22 Jan 2015 02:47:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Jan 2015 02:47:30 -0000 Authentication-Results: pb1.pair.com smtp.mail=xinchen.h@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@php.net; sender-id=unknown Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.50 as permitted sender) X-PHP-List-Original-Sender: xinchen.h@zend.com X-Host-Fingerprint: 209.85.215.50 mail-la0-f50.google.com Received: from [209.85.215.50] ([209.85.215.50:33984] helo=mail-la0-f50.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FB/8E-49046-FB460C45 for ; Wed, 21 Jan 2015 21:47:27 -0500 Received: by mail-la0-f50.google.com with SMTP id pn19so43653810lab.9 for ; Wed, 21 Jan 2015 18:47:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=sTGlnU4V/tyXhlZMDFH7OEJFBbYpAKYyDOfMwAlvjps=; b=JIHAGVECmNR5TruusNspj8HsLWHnDM12aLcm6k5xvHw7twoe1fNNI3MwoYsEvVI8VA uw+E9xbIV3PZPSAM7phlultuiTITIrwpBqmj3yD1xatY1toUZEeHyMK7WiJ7WDt/IgDf Qffpwbmv6UOFLwdl0aJgkxe2LDy8Cub2i24jMprop11Ly2fwVI8wmFxQqKlCH7EA2D1o SXnexxbv08tI0hnuZQ5eTE/gOxv0/QYF7DDyaNELXdg0imJ5UxMvuL/D2cEh8cyNWVag Ttr8gxW9ljoxq7sVMMw/AeZBJTnZREwTN/duDP/UhmIX6+Yio6nkSiR7JL9wFWGWxolO WpHw== X-Gm-Message-State: ALoCoQlNT5Id2VfekOxciEpTds0aDbCf8RMIgdeCQ+OPbcCZ4CMFxPBTSYdSaZg8gdSTbEAReSyG+zNqx355M4nICms3FtE5Dv98nPRkdn0HdAKgDu6bcqShmehNg/Hw8WjHlCyu7YH+oTzoGPeVU5sxUu6AH2HqvQ== X-Received: by 10.112.154.70 with SMTP id vm6mr47816432lbb.18.1421894844174; Wed, 21 Jan 2015 18:47:24 -0800 (PST) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com. [209.85.215.43]) by mx.google.com with ESMTPSA id qn2sm135792lbb.38.2015.01.21.18.47.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Jan 2015 18:47:22 -0800 (PST) Received: by mail-la0-f43.google.com with SMTP id q1so28464508lam.2 for ; Wed, 21 Jan 2015 18:47:21 -0800 (PST) X-Received: by 10.112.129.195 with SMTP id ny3mr48336020lbb.10.1421894841901; Wed, 21 Jan 2015 18:47:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.64.176 with HTTP; Wed, 21 Jan 2015 18:47:01 -0800 (PST) In-Reply-To: <1421864838-21962-2-git-send-email-git@internot.info> References: <1421864838-21962-1-git-send-email-git@internot.info> <1421864838-21962-2-git-send-email-git@internot.info> Date: Thu, 22 Jan 2015 10:47:01 +0800 Message-ID: To: Joshua Rogers Cc: PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [PATCH 2/3] Fix null pointer dereference From: laruence@php.net (Xinchen Hui) Hey: On Thu, Jan 22, 2015 at 2:27 AM, Joshua Rogers wrote: > --- > > These issues are not serious(only triggerable by the runner/caller of the PHP program), so no need to make them private. > > sapi/litespeed/lsapi_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sapi/litespeed/lsapi_main.c b/sapi/litespeed/lsapi_main.c > index 2b2385c..d767306 100644 > --- a/sapi/litespeed/lsapi_main.c > +++ b/sapi/litespeed/lsapi_main.c > @@ -487,7 +487,7 @@ static int lsapi_chdir_primary_script( zend_file_handle * file_handle ) > getcwd( s_cur_chdir, sizeof( s_cur_chdir ) ); > > p = strrchr( file_handle->filename, '/' ); > - if ( *p ) > + if ( p ) > { > *p = 0; > if ( strcmp( file_handle->filename, s_cur_chdir ) != 0 ) { > -- > 1.9.1 > thanks for the recently great reporting.. myabe, you could send these patch via bugs.php.net, or github PR? it's better than mails :) thanks > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/