Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80921
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain thomasbley.de from 85.13.137.24 cause and error)
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: ALL-INKL Webmail 2.11
To: internals@lists.php.net
Message-ID: <20150121043939.5129B26183A@dd15934.kasserver.com>
Date: Wed, 21 Jan 2015 05:39:39 +0100 (CET)
Subject: Enable error_handler callback parameters to be passed by reference
From: mails@thomasbley.de ("Thomas Bley")

In userland it is sometimes necessary to extend PHP's notices/warnings with additional information (e.g. username from session, stack trace, etc.)
I'm proposing to enable error_handler callback parameters to be passed by reference to be able to append additional data to error messages.

Example:

<?php
ini_set('error_reporting', E_ALL);
ini_set('display_errors', 0);
ini_set('log_errors', 1);
ini_set('error_log', 'php_error.log');

function myErrorHandler($errno, &$errstr, $errfile, $errline) {
  if (!empty($_SESSION['username'])) {
    $errstr .= ', username: '.$_SESSION['username'];
  }
  return false; // continue normal error handler
}

set_error_handler("myErrorHandler");

function test() {
  echo tests; // Use of undefined constant tests
}

test();

Gives in php_error.log:
[21-Jan-2015 04:32:26 UTC] PHP Notice:  Use of undefined constant tests - assumed 'tests', username: ... in error.php on line 17

Instead of:
[21-Jan-2015 04:32:26 UTC] PHP Notice:  Use of undefined constant tests - assumed 'tests' in error.php on line 17

Regards
Thomas