Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80917
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.192.42 as permitted sender)
Message-ID: <54BEE31B.3020403@lerdorf.com>
Date: Tue, 20 Jan 2015 15:22:03 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Stanislav Malyshev <smalyshev@gmail.com>, 
 PHP internals <internals@lists.php.net>
References: <54BECE9E.5050502@lerdorf.com> <54BED307.5010606@lerdorf.com> <54BEDABB.2040406@gmail.com>
In-Reply-To: <54BEDABB.2040406@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="Tcu7Grwc6EJ5rb32Dd6N1OioU08PewTns"
Subject: Re: [PHP-DEV] Re: Help - gcc mystery in ext/imap
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--Tcu7Grwc6EJ5rb32Dd6N1OioU08PewTns
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/20/2015 02:46 PM, Stanislav Malyshev wrote:
> Hi!
>=20
>> So, I guess the lesson is that we need to be careful when we migrate
>> extensions to PHP 7. Passing ints instead of size_t string length para=
ms
>> to zpp can cause extreme weirdness and we should go through all our
>> bundled extensions and make sure things that are still using "s" have
>> all been changed to size_t.
>=20
> Definitely so. I've recently went through intl and fixed a bunch of
> int/size_t issues, but judging from how many there were, I assume other=

> non-trivial extensions would have such things too. We have lots of
> places where size_t and int are intermixed - e.g., random try, go to
> mysqli extension, do grep int *.c | grep len and see that results of
> spprintf - which returns size_t - are put into int. Now, in this case
> it's almost 100% not a problem, but illustrates bigger issue of mixing
> the types, and in some cases it may be a real problem.

Yeah, I was quite surprised by the weirdness it caused. I don't think I
have ever seen something that breaks under -O2 start working again
compiled with -O3. That's what had me chasing my tail into assembly
world for a bit there.

I have fixed up ext/imap now. Hopefully I caught them all.

-Rasmus



--Tcu7Grwc6EJ5rb32Dd6N1OioU08PewTns
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlS+4xsACgkQlxayKTuqOuATOQCfSO4td7lx3c39i8Xjj5B+bgUK
1WAAnRgRs25fSXqIxdUxO+YKdyBjJ1hX
=XWgE
-----END PGP SIGNATURE-----

--Tcu7Grwc6EJ5rb32Dd6N1OioU08PewTns--