Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80914 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 5314 invoked from network); 20 Jan 2015 22:39:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Jan 2015 22:39:34 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.215.10 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 217.114.215.10 mail.experimentalworks.net Received: from [217.114.215.10] ([217.114.215.10:37837] helo=mail.experimentalworks.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 27/4B-49046-429DEB45 for ; Tue, 20 Jan 2015 17:39:32 -0500 Received: by mail.experimentalworks.net (Postfix, from userid 1003) id 245BC48769; Tue, 20 Jan 2015 23:39:57 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on km31408.keymachine.de X-Spam-Level: * X-Spam-Status: No, score=1.4 required=3.0 tests=ALL_TRUSTED, DNS_FROM_AHBL_RHSBL autolearn=no version=3.3.2 X-Spam-HAM-Report: * 2.4 DNS_FROM_AHBL_RHSBL RBL: Envelope sender listed in dnsbl.ahbl.org * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Received: from [192.168.2.34] (ppp-93-104-12-121.dynamic.mnet-online.de [93.104.12.121]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: johannes@schlueters.de) by mail.experimentalworks.net (Postfix) with ESMTPSA id 1F1CA48769; Tue, 20 Jan 2015 23:39:55 +0100 (CET) Message-ID: <1421793543.8614.8.camel@kuechenschabe> To: Rasmus Lerdorf Cc: PHP internals Date: Tue, 20 Jan 2015 23:39:03 +0100 In-Reply-To: <54BED307.5010606@lerdorf.com> References: <54BECE9E.5050502@lerdorf.com> <54BED307.5010606@lerdorf.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-8j8K/2CQmS4txfqhAID+" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Subject: Re: [PHP-DEV] Re: Help - gcc mystery in ext/imap From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=) --=-8j8K/2CQmS4txfqhAID+ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-01-20 at 14:13 -0800, Rasmus Lerdorf wrote: > So, I guess the lesson is that we need to be careful when we migrate > extensions to PHP 7. Passing ints instead of size_t string length params > to zpp can cause extreme weirdness and we should go through all our > bundled extensions and make sure things that are still using "s" have > all been changed to size_t. There is this plugin to clang's static analyzer which should help: https://github.com/johannes/clang-php-checker It might needs updates for current types, though. Relevant code place to update: https://github.com/johannes/clang-php-checker/blob/master/PHPZPPChecker.cpp= #L67 johannes --=-8j8K/2CQmS4txfqhAID+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAABAgAGBQJUvtkcAAoJEH3sTmn8nIPXW+sH/0HzGoKGzQrkp+GAIsUBRpO2 2xzq2S5U/7CWoD3xMi8AQHeneGIAok7Xr6iK4FBqDgquxB+IiVnRiXX9A+GZEmQ/ fmUvHHM42+tqpxBNvWcoo5UYicc5z318VzgSIBrlfZlthLxTlmK57FRdD1rcFy1H M4+T/Mo54zbAUB4ZqNMp1MPmFV2weIMsjowt5IsyNi0CrWmzNxIauXsXbYN0JqdH xumxTnms2JcGJLDVa2d0SV07OkGoQgIj5PR87elRxd3kmrnOw5h6XU+hWi20Fv2Y WUtOtIrnvUgrtna0IhXv9H7l3+XoND9E2gFMETXT0pSKarZMYE2VOT9EzJo9+Y8= =tfau -----END PGP SIGNATURE----- --=-8j8K/2CQmS4txfqhAID+--