Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80910
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.216.172 as permitted sender)
Message-ID: <54BED307.5010606@lerdorf.com>
Date: Tue, 20 Jan 2015 14:13:27 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
References: <54BECE9E.5050502@lerdorf.com>
In-Reply-To: <54BECE9E.5050502@lerdorf.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="MCouBkmU6LPETGspSVN6HlVaksLbPU0xj"
Subject: Re: Help - gcc mystery in ext/imap
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--MCouBkmU6LPETGspSVN6HlVaksLbPU0xj
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/20/2015 01:54 PM, Rasmus Lerdorf wrote:
> Things I have tried. changed it from "p" to "s" and also from "p" to "S=
"
> and using a zend_string * instead. In both cases I got the same bogus
> address back from zpp. Right now I am trying to make sense of the
> generated assembly differences, but it is slow going.

It looks like I might have messed up the zend_string try before. Both
Nikic and Michael suggested it probably had to to with int instead of
size_t for the arg lengths, which I had considered but figured since it
also broke with a zend_string which brings along the right length type
that wasn't it. But, re-applying my patch:

  https://gist.github.com/anonymous/713089b9acca67bce42e

seems to have fixed it.

So, I guess the lesson is that we need to be careful when we migrate
extensions to PHP 7. Passing ints instead of size_t string length params
to zpp can cause extreme weirdness and we should go through all our
bundled extensions and make sure things that are still using "s" have
all been changed to size_t.

-Rasmus


--MCouBkmU6LPETGspSVN6HlVaksLbPU0xj
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlS+0wcACgkQlxayKTuqOuCpegCeNUW5Wgyr/CnH/RkJuHMxn9Pc
BxoAn16dCE3KWPQAC1psJU/KSmkHHYDl
=/SS0
-----END PGP SIGNATURE-----

--MCouBkmU6LPETGspSVN6HlVaksLbPU0xj--