Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80885 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46631 invoked from network); 20 Jan 2015 18:35:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Jan 2015 18:35:10 -0000 Authentication-Results: pb1.pair.com smtp.mail=honey@internot.info; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=honey@internot.info; sender-id=pass Received-SPF: pass (pb1.pair.com: domain internot.info designates 185.57.82.47 as permitted sender) X-PHP-List-Original-Sender: honey@internot.info X-Host-Fingerprint: 185.57.82.47 mail.internot.info Received: from [185.57.82.47] ([185.57.82.47:54740] helo=mail.internot.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F5/42-32230-EDF9EB45 for ; Tue, 20 Jan 2015 13:35:10 -0500 Message-ID: <54BE9FD5.7060901@internot.info> Date: Wed, 21 Jan 2015 05:35:01 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 To: internals@lists.php.net References: <1421776826-8333-1-git-send-email-git@internot.info> <277598E9-B10F-46E3-BD32-52AEBB34A14D@gmail.com> In-Reply-To: <277598E9-B10F-46E3-BD32-52AEBB34A14D@gmail.com> OpenPGP: id=296E6003; url=https://internot.info/docs/gpg_pubkey.asc.gpg Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RJakWg5m3sPoNO2TbV61DuS0DRQhgh3nt" Subject: Re: [PHP-DEV] [PATCH] Remove useless tests From: honey@internot.info (Joshua Rogers) --RJakWg5m3sPoNO2TbV61DuS0DRQhgh3nt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 21/01/15 05:32, Alexey Zakhlestin wrote: >> > On 20 Jan 2015, at 21:00, Joshua Rogers wrote: >> >=20 >> > Respective variables are unsigned and cannot be <0. > Did you mean to use =E2=80=9C=3D=3D=E2=80=9C in comparisons? > > Yes. Fixed it in the pull request: https://github.com/MegaManSec/php-src/commit/eba0e0348e972219675e48356bd5= e74dacb04522 --=20 -- Joshua Rogers --RJakWg5m3sPoNO2TbV61DuS0DRQhgh3nt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUvp/VAAoJEJCcj5QpbmAD+oMQAJLt07odqtJyLyPpQ9FBin6M 8DJbCeaDx6Ih9ngUv/cG06KxgJ5neux6wippg81dpGLCMuN5AatKUA0miDt/umCk pbfgWCkaNw23PMCw3jjQZ8JzGRlkMLrzmc9LotPiqxkAXiKa9EbELZd8ZD7DIE2A ievybSNDPdS+EJnLYIyCalY8WdKg6t+u8ivMjStb0opOxW/FKIhUziOG8Ge8z6gm T8tSZkgDeQaslY2BJw3CJuEFb8hu298Vq+IqcJxbEcTvNPo/LeC9eXt+73BtUFqX BIMuXUCiSOFkDlL/Ph4Xx7XOrwMywmNPLYLuMdfFXfLuf9pFmo76P4cn5GLJOn2l Mnd4IfgvUzRIsdDrb0GU8PRypfAmeB1JC08iEwgDyn/GQArDL8mPF+KdNcrWvScM QIkgoubgS0QUTOKRnRoRakKKkVtYWH9kcRnDIVNeVl0mrS3f2lRbEsuGfiDOSbD5 K0T1o4h9RHeX7/0jWEEYVM7zP2Jq8Gv3etlOJqZoAr9OSWNoAo2zd/HeEyBSeMXr Y6sJdf+0zdu6brgZtbEooPvNZwfdtimcetCe/Ivd+j2hJrjXNsjXtQXxUjZcPXgK ozOj9RiZTyjqkG4kBj6hIGsIZ4L29RkhD33XNEz5VQ8QX2cvnI3McGXhEFR1cUI8 8rQn6yFLRnNzDiEnNKiR =NdLa -----END PGP SIGNATURE----- --RJakWg5m3sPoNO2TbV61DuS0DRQhgh3nt--