Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80884
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.172 as permitted sender)
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
Content-Type: multipart/signed; boundary="Apple-Mail=_BD63C7F7-7F9A-48AA-BD99-12BBCBAA8481"; protocol="application/pgp-signature"; micalg=pgp-sha512
In-Reply-To: <1421776826-8333-1-git-send-email-git@internot.info>
Date: Tue, 20 Jan 2015 21:32:52 +0300
Cc: internals@lists.php.net
Message-ID: <277598E9-B10F-46E3-BD32-52AEBB34A14D@gmail.com>
References: <1421776826-8333-1-git-send-email-git@internot.info>
To: Joshua Rogers <git@internot.info>
Subject: Re: [PHP-DEV] [PATCH] Remove useless tests
From: indeyets@gmail.com (Alexey Zakhlestin)

--Apple-Mail=_BD63C7F7-7F9A-48AA-BD99-12BBCBAA8481
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On 20 Jan 2015, at 21:00, Joshua Rogers <git@internot.info> wrote:
>=20
> Respective variables are unsigned and cannot be <0.

Did you mean to use =E2=80=9C=3D=3D=E2=80=9C in comparisons?


> ---
> sapi/litespeed/lsapilib.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>=20
> diff --git a/sapi/litespeed/lsapilib.c b/sapi/litespeed/lsapilib.c
> index 2e60701..20279d1 100644
> --- a/sapi/litespeed/lsapilib.c
> +++ b/sapi/litespeed/lsapilib.c
> @@ -1442,16 +1442,16 @@ int LSAPI_ReqBodyGetLine_r( LSAPI_Request * =
pReq, char * pBuf, size_t bufLen, in
>     char * pBufCur =3D pBuf;
>     char * pCur;
>     char * p;
> -    if (!pReq || (pReq->m_fd =3D=3D-1) ||( !pBuf )||(bufLen < 0 )|| =
!getLF )
> +    if (!pReq || (pReq->m_fd =3D=3D-1) ||( !pBuf )|| !getLF )
>         return -1;
>     *getLF =3D 0;
>     while( (left =3D pBufEnd - pBufCur ) > 0 )
>     {
>=20
>         len =3D pReq->m_bufRead - pReq->m_bufProcessed;
> -        if ( len <=3D 0 )
> +        if ( len =3D 0 )
>         {
> -            if ( (len =3D readBodyToReqBuf( pReq )) <=3D 0 )
> +            if ( (len =3D readBodyToReqBuf( pReq )) =3D 0 )
>             {
>                 *getLF =3D 1;
>                 break;
> @@ -1486,7 +1486,7 @@ ssize_t LSAPI_ReadReqBody_r( LSAPI_Request * =
pReq, char * pBuf, size_t bufLen )
>     ssize_t len;
>     off_t total;
>     /* char *pOldBuf =3D pBuf; */
> -    if (!pReq || (pReq->m_fd =3D=3D-1) || ( !pBuf )||(bufLen < 0 ))
> +    if (!pReq || (pReq->m_fd =3D=3D-1) || ( !pBuf ))
>         return -1;
>=20
>     total =3D pReq->m_reqBodyLen - pReq->m_reqBodyRead;
> @@ -1517,7 +1517,7 @@ ssize_t LSAPI_ReadReqBody_r( LSAPI_Request * =
pReq, char * pBuf, size_t bufLen )
>             pBuf +=3D len;
>             bufLen -=3D len;
>         }
> -        else if ( len <=3D 0 )
> +        else if ( len =3D 0 )
>         {
>             if ( !total)
>                 return -1;
> --
> 1.9.1
>=20
>=20
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20

--
Alexey Zakhlestin
CTO at Grids.by/you
https://github.com/indeyets
PGP key: http://indeyets.ru/alexey.zakhlestin.pgp.asc




--Apple-Mail=_BD63C7F7-7F9A-48AA-BD99-12BBCBAA8481
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQEbBAEBCgAGBQJUvp9eAAoJEMkJcRxZdR277Q4H+K2vEh/NydEL8P0434QnjzMw
czI8FK0PeUeBWA6+VhdMUaqYQ8tXGn7vtJ1767CLvOXwjtZLTuGl6jrkWj3J/aBZ
jxrZ7FO2Na5teZhKYRhtrJWv7SdUWd6qTiuOXDFKADy3r0wKXw/usJdyywsEZ5SY
NL5z7BOrp1gZ50/u4/6XuPFHWAMoVRnjnlydWMyidSm0kcOAAvHdP7rq/gEpKotc
b5+fadMjKc7QvLDI8wQlE/5HMkrRz4ir6xUlhN/cycc7gE0+qxdvP5NmuumySYTx
VymPtsdTs8lWJPAevbDimDG8ybq9nYrr7nyGaM4hEVyTe/vC3sUYx63XPLr/QQ==
=Bmp+
-----END PGP SIGNATURE-----

--Apple-Mail=_BD63C7F7-7F9A-48AA-BD99-12BBCBAA8481--