Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80846 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 30007 invoked from network); 19 Jan 2015 19:23:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jan 2015 19:23:12 -0000 Authentication-Results: pb1.pair.com smtp.mail=honey@internot.info; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=honey@internot.info; sender-id=pass Received-SPF: pass (pb1.pair.com: domain internot.info designates 185.57.82.47 as permitted sender) X-PHP-List-Original-Sender: honey@internot.info X-Host-Fingerprint: 185.57.82.47 mail.internot.info Received: from [185.57.82.47] ([185.57.82.47:36182] helo=mail.internot.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 6E/40-64889-F995DB45 for ; Mon, 19 Jan 2015 14:23:12 -0500 Message-ID: <54BD5998.4050806@internot.info> Date: Tue, 20 Jan 2015 06:23:04 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 To: internals@lists.php.net References: <1421694958-14772-1-git-send-email-git@internot.info> In-Reply-To: <1421694958-14772-1-git-send-email-git@internot.info> OpenPGP: id=296E6003; url=https://internot.info/docs/gpg_pubkey.asc.gpg Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="krRuEssbACHShw0BsPuIxDEtpCWi4xMuM" Subject: Re: [PHP-DEV] [PATCH] Fix potential int overflow in date extension. From: honey@internot.info (Joshua Rogers) --krRuEssbACHShw0BsPuIxDEtpCWi4xMuM Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 20/01/15 06:15, Joshua Rogers wrote: > -- > ext/date/lib/tm2unixtime.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Somebody please take a look at /ext/date/lib/parse_tz.c too: 438timelib_sll timelib_get_current_offset(timelib_time *t) [..] 446 return (t->z + t->dst) * -60; Should that be cast timelib_sll too? I think perhaps the function should be an int, seeing as it looks like the result should be negative. Somebody please check. --=20 -- Joshua Rogers --krRuEssbACHShw0BsPuIxDEtpCWi4xMuM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUvVmYAAoJEJCcj5QpbmADFRMP/0L+UhpkldwsPAKoXZGgJNrT ELZCTjRE2QkmUXHQYFfTDrA/S7KNPywaf6ZpMnZriOtzxv43Sb6WxIApplMG6cvV 8UJgQm7ehhnLWRAsxusnqHZXvLkWWq+VbA3GUAEVM94Wafe3SFmc5m7h5loQXwV5 p4vHjHd0C2S2EuL7vZK/HIolp6Oj+U9mgOkr+FAPsERNGxv1m1R/N4XDd96guOXe OO+cQq8Q0pzRH0Xrg9iWr9eBRqNpFOsU0gfltdUCEdGKnpAmL3JHzbw3TiIAFgnr M/icBkiWBNyN+wQ9SfAlvxGF+TXE7jNEMsloeBqTPEqBhDD+FebBSyg/QqBkaCxD EUKbF9vM15ggIRludUsE8jz2dBlAeZ1b48hDuRBSpjL7f8P+FQ2CNtzua0UFE+4a YZn9+LDJ0Nj8IcZO59FxzqDMylD5UvDdvstGFfoWfX5BrvUYoKpC2GD1pCKd6ejx fGXjSsPws+N7GS1yE6NQYiBTuIH92o5L5e+idifQttaP8lqF3nvUNd5XbQ9a0lgj YdPjGu9Wg42SWhltG7JSRx+AYAv5czcF0TApq7IEUQOq7UNxKDXLosnzKn9gIEZY p8XZhjrUQvnb/IgEy34Kt73guFPrYFj13V1jwvKPa3fjJfezmVtmi/6lRvhluvCb mu2PKtXoLrL31qPX8ZaE =il0U -----END PGP SIGNATURE----- --krRuEssbACHShw0BsPuIxDEtpCWi4xMuM--