Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80825
Return-Path: <sebastian@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 86991 invoked from network); 19 Jan 2015 15:07:26 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 19 Jan 2015 15:07:26 -0000
Authentication-Results: pb1.pair.com smtp.mail=sebastian@php.net; spf=unknown; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=sebastian@php.net; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 93.190.64.238 as permitted sender)
X-PHP-List-Original-Sender: sebastian@php.net
X-Host-Fingerprint: 93.190.64.238 mail-2.de-punkt.de  
Received: from [93.190.64.238] ([93.190.64.238:35131] helo=mail-99.de-punkt.de)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id BD/28-64889-CAD1DB45 for <internals@lists.php.net>; Mon, 19 Jan 2015 10:07:26 -0500
Received: from localhost (localhost [127.0.0.1])
	by mail-99.de-punkt.de (Postfix) with ESMTP id 0A5CD3A2D4
	for <internals@lists.php.net>; Mon, 19 Jan 2015 16:07:22 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at mail-2.de-punkt.de
Received: from mail-99.de-punkt.de ([127.0.0.1])
	by localhost (mail-2.de-punkt.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 7rNg-Cun8I8R for <internals@lists.php.net>;
	Mon, 19 Jan 2015 16:07:21 +0100 (CET)
Received: from [192.168.178.24] (p57BDEB8B.dip0.t-ipconnect.de [87.189.235.139])
	(Authenticated sender: php@sebastian-bergmann.de)
	by mail-99.de-punkt.de (Postfix) with ESMTPSA id 8C29A3A2D2
	for <internals@lists.php.net>; Mon, 19 Jan 2015 16:07:21 +0100 (CET)
Message-ID: <54BD1DA9.2050303@php.net>
Date: Mon, 19 Jan 2015 16:07:21 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <54BB7170.4060905@beccati.com> <54BCAB09.4050408@gmail.com>
In-Reply-To: <54BCAB09.4050408@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] PEAR and make install on master
From: sebastian@php.net (Sebastian Bergmann)

Am 19.01.2015 um 07:58 schrieb Stanislav Malyshev:
> Can't we just fix it? As I understand, it's just making this:
> 
>     function initializeConfig(&$config)
> 
> into this:
> 
>     static function initializeConfig(&$config)
> 
> In PEAR/Installer/Role.php but I'm not sure where to commit the patch or
> how to get it into phars (they don't seem to be the latest code in git).
> Anybody knows what's the right way here?

 I checked out pear/pear-core.git but cannot figure out how to run
 the test suite. Don't want to commit a change without running the
 tests ...