Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80747
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAESVnVoK3b+m6-2z_vsF3GfQ+CSOWBsGS_v-6v0ZSb83=oyKEw@mail.gmail.com>
References: <CAESVnVoK3b+m6-2z_vsF3GfQ+CSOWBsGS_v-6v0ZSb83=oyKEw@mail.gmail.com>
Date: Sun, 18 Jan 2015 17:50:33 +0100
Message-ID: <CAF+90c_Uh8uZYFx8An4gLgxRN+Oa415r+m8=gbifhQ3t7UnRjA@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c34850199a0e050cf00101
Subject: Re: [PHP-DEV] Mind if I hook the compiler?
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11c34850199a0e050cf00101
Content-Type: text/plain; charset=UTF-8

On Sun, Jan 18, 2015 at 3:58 AM, Sara Golemon <pollita@php.net> wrote:

> https://github.com/php/php-src/pull/1004
>
> Wondering if anyone has an objection to me merging this.  It just
> offers extensions a chance to alter the AST prior to bytecode
> emission.  Mostly for evil things, but potentially for 3rd-party
> optimizers or whatevs.  Does it need an RFC?  The very minor
> indirection cost hides itself behind OpCache, so it should harm
> anything...
>

Totally okay with making that hookable, but not sure if compile_top_stmt is
the best place to do that, at least in the form implemented in the PR.
Assuming that you want to implement a preprocessing pass on the AST the
fast that zend_compile_top_stmt is called recursively might be somewhat
inconvenient. Maybe compile_top_stmt should at least also call
compile_top_stmt instead of zend_compile_top_stmt?

Nikita

--001a11c34850199a0e050cf00101--