Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80685 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 50564 invoked from network); 17 Jan 2015 09:51:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Jan 2015 09:51:47 -0000 Authentication-Results: pb1.pair.com header.from=lester@lsces.co.uk; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=lester@lsces.co.uk; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 217.147.176.214 cause and error) X-PHP-List-Original-Sender: lester@lsces.co.uk X-Host-Fingerprint: 217.147.176.214 mail4-2.serversure.net Linux 2.6 Received: from [217.147.176.214] ([217.147.176.214:59191] helo=mail4.serversure.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 30/60-47555-2B03AB45 for ; Sat, 17 Jan 2015 04:51:47 -0500 Received: (qmail 11969 invoked by uid 89); 17 Jan 2015 09:51:43 -0000 Received: by simscan 1.3.1 ppid: 11959, pid: 11966, t: 0.0648s scanners: attach: 1.3.1 clamav: 0.96/m:52/d:10677 Received: from unknown (HELO ?10.0.0.8?) (lester@rainbowdigitalmedia.org.uk@86.189.147.37) by mail4.serversure.net with ESMTPA; 17 Jan 2015 09:51:43 -0000 Message-ID: <54BA30AE.3090208@lsces.co.uk> Date: Sat, 17 Jan 2015 09:51:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors From: lester@lsces.co.uk (Lester Caine) On 17/01/15 05:54, Pierre Joye wrote: >> > Andrea Faulds has kindly written a utility that identifies when a PHP >> > 4 constructor is defined[2]. It does not automatically change the code >> > for liability reasons. The utility PHPMD[3] can also detect this but >> > has a false positive when `__construct` is also defined. > Not much to say about it as it is a taste/yes/no thing. > > Let wait the required period and move to vote, I do not see much needs > to argue in a circular way forever :) Switching code to __construct is on my 5.2 to 5.4 upgrade crib sheet. I thought because e_strict moans about it? But on a quick scan I can't find a reference other than NOT flagging a warning when different parameters are used. Obviously this modernise is useful anyway, but where does it fit in the error handling currently? -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk