Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80618 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 44815 invoked from network); 16 Jan 2015 07:34:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Jan 2015 07:34:54 -0000 Authentication-Results: pb1.pair.com header.from=honey@internot.info; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=honey@internot.info; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain internot.info designates 185.57.82.47 as permitted sender) X-PHP-List-Original-Sender: honey@internot.info X-Host-Fingerprint: 185.57.82.47 mail.internot.info Received: from [185.57.82.47] ([185.57.82.47:57055] helo=mail.internot.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F3/E0-39838-D1FB8B45 for ; Fri, 16 Jan 2015 02:34:54 -0500 Message-ID: <54B8BF15.7070704@internot.info> Date: Fri, 16 Jan 2015 18:34:45 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 To: internals@lists.php.net References: <1421339511-9078-1-git-send-email-git@internot.info> <54B7EDAC.3060005@php.net> <54B7EF5D.1060001@internot.info> In-Reply-To: <54B7EF5D.1060001@internot.info> OpenPGP: id=296E6003; url=https://internot.info/docs/gpg_pubkey.asc.gpg Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UFLQcExiwjuQoN7mONQUGsSJJRcoTob4M" Subject: Re: [PHP-DEV] [PATCH] Fixed bug #68839 Possible null pointer dereference From: honey@internot.info (Joshua Rogers) --UFLQcExiwjuQoN7mONQUGsSJJRcoTob4M Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 16/01/15 03:48, Joshua Rogers wrote: > Should the patch, perhaps be inside the spprintf() function? > That would take care of future problems, too. > > Thoughts? Ok, so, there are many many places where 'error' is not checked against NULL. So I'm going to submit a patch that will fix this in the spprintf function instead of each use-case. Thanks, --=20 -- Joshua Rogers --UFLQcExiwjuQoN7mONQUGsSJJRcoTob4M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUuL8VAAoJEJCcj5QpbmADbhUP/37nOE5yu/7RfVvELgb+u7/m cu076eoOZg4qeXPUNehURIHCsk92xeLvZ4lbrA67LT6ssAp/SaIUUFBkto4NKvQK EGU26JE4MvwvMSKNU+9ja0+JM5hviZqxHgVxMxmxJryELrJKmHReu3nXzWv+pp05 LfRPrSm9L3n8Xzs//uN+x2zgFaaMWvi2Wf74gy9J5lzoz4C7X2PVDD5Br4H7VOkk sQ3lzkvEsjVjeshrA/zNwGLFt6NMDDPv12AdMEn/1tOl6sCdlSX6yycEpmJGVSFo 5Fll/hBFXgRqqHg7E8ffiPcNZaPeo83ibdNm4UgaAzoqXvy+R4N7xpcSD2OTS8aG KRwHcqW4Z/sRhOdkPMgb2E1Ty4ZI2l6vaLdmTZdn7MJLAJn/M3/awKNnnLWn/Kr4 HiKARLenygVL1TJazNOUSzsKtwIIT/Ougnyj3apQgNYSTPW3ESNQVe4wBVwRG5eF OqsoBxzLYjBp/iaI3kd9RdoEkvl/0zQjhrk+0+D8aYFheZGgh/XfjLTBY3+DSleQ qq/GBI665oFsILOVTJdvDvEhj3G9X5/nAYu/3P/mLi64B+Sr5xfgCHrbbG/DN38u IOomJIOiHOGeWPLZHzsBYXNtUbLLe+JuvBV/vfXqAZ13Ug3IhLzuynHkmThH8IpI DYIy0rKOMAkm6PCoqQD7 =EiP7 -----END PGP SIGNATURE----- --UFLQcExiwjuQoN7mONQUGsSJJRcoTob4M--