Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80569 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 30476 invoked from network); 15 Jan 2015 16:48:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Jan 2015 16:48:37 -0000 Authentication-Results: pb1.pair.com smtp.mail=honey@internot.info; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=honey@internot.info; sender-id=pass Received-SPF: pass (pb1.pair.com: domain internot.info designates 185.57.82.47 as permitted sender) X-PHP-List-Original-Sender: honey@internot.info X-Host-Fingerprint: 185.57.82.47 mail.internot.info Received: from [185.57.82.47] ([185.57.82.47:49100] helo=mail.internot.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8F/55-14306-46FE7B45 for ; Thu, 15 Jan 2015 11:48:36 -0500 Message-ID: <54B7EF5D.1060001@internot.info> Date: Fri, 16 Jan 2015 03:48:29 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 To: internals@lists.php.net References: <1421339511-9078-1-git-send-email-git@internot.info> <54B7EDAC.3060005@php.net> In-Reply-To: <54B7EDAC.3060005@php.net> OpenPGP: id=296E6003; url=https://internot.info/docs/gpg_pubkey.asc.gpg Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GDvN7X9g9fSGJuRqXEp1Wcwb8C77sdhmt" Subject: Re: [PHP-DEV] [PATCH] Fixed bug #68839 Possible null pointer dereference From: honey@internot.info (Joshua Rogers) --GDvN7X9g9fSGJuRqXEp1Wcwb8C77sdhmt Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi, On 16/01/15 03:41, Michael Wallner wrote: > Looks good. There's another one(2) in /ext/phar/util.c: --snip-- 911 if (error) { 912 *error =3D NULL; 913 } 914 /* seek to start of internal file and read it */ 915 if (FAILURE =3D=3D phar_open_entry_fp(entry, error, 1)) { 916 return NULL; 917 } =20 918 if (-1 =3D=3D phar_seek_efp(entry, 0, SEEK_SET, 0, 1)) { 919 spprintf(error, 4096, "phar error: cannot seek to sta= rt of file \"%s\" in phar \"%s\"", entry->filename, phar->fname); 920 return NULL; 921 } --snip-- Should the patch, perhaps be inside the spprintf() function? That would take care of future problems, too. Thoughts? Thanks, --=20 -- Joshua Rogers --GDvN7X9g9fSGJuRqXEp1Wcwb8C77sdhmt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUt+9dAAoJEJCcj5QpbmADKnoP/AlxBICj+rNYzeaIB/zOVHGT F4Z5mGLfIRTSc4mObkw/XQlSdYFmNnvnPaUcV7frqFqx0f514Jx4yfJCHXRY2nk6 zmTRo6Y2lLyDvn22e6+BL9RUgN7APwBMgPFu9lerQva7QxL+xMRwn4Pb7yDEo6IN CP/heyifUSmtTuSgtHEzcdD6tYYn0goTiMduzzyWE5uZVL+VaH3c19U3WtGl84CB XsFM4SisMST7qHzwjccdAb9Vi1/1ROh2/hS6jne/tMamFqtgNChPMS4RysFbDkO+ s7z6QJvrZ+7pl0D+eFv0AA/coRGhvFwfq8U9hmdHXS926wRFB9aBoUVPy6G7c+eE I+1HfbFBXcXpxk+1kXGm0hhJVnEVlPoz3QMnDn1bgt0/YybXoRp+RhJkS3u8vqnx DFZguMjeyq6msxaQfcQw69/QXDOGDwtXRxhMng8VK5vFWRiCHjN7XtuNTbpY6KWY DCupauSCfszleIebhleYdHgknGcUfC8/DdFKE1qnnh9wxytrn7zTKeZQBBAgJdSQ iWHN8lSYvGHZbKE7k0r9HgK6iryZqox/x8ufIo8u0Rosk3DI+hI7S5K3ypeBV7eU MN/GFSC654yYc9wSUHSrFH8vZB7RL/MOyqOUcISSGa5CgiY1pXcSG3OjlDu2UGip cHKyLHA3MYzlczARxFW5 =LIN+ -----END PGP SIGNATURE----- --GDvN7X9g9fSGJuRqXEp1Wcwb8C77sdhmt--