Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80549
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54B7D8AE.5090209@seld.be>
References: <8DCD1B72-C81D-499E-B455-E4A042CD76E6@ajf.me>
	<54B7D8AE.5090209@seld.be>
Date: Thu, 15 Jan 2015 16:25:54 +0100
Message-ID: <CAB6YZuxA5F7DT+4F5FznrTuw_jR52-0KD2MPvMqhUhs-h9B-2g@mail.gmail.com>
To: Jordi Boggiano <j.boggiano@seld.be>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2
From: pajousek@gmail.com (=?UTF-8?Q?Pavel_Kou=C5=99il?=)

On Thu, Jan 15, 2015 at 4:11 PM, Jordi Boggiano <j.boggiano@seld.be> wrote:
>
> Reading the thread at this point shows so much confusion, it seems half the
> people reading the spec misunderstood that the declare() line affects
> function calls only and not the API/implementation level.
>
> As much I think it was a smart idea and workaround, it is perhaps too clever
> for its own good if nobody gets it.
>
> Anyway, as v0.2 appears to be v0.1 + declare(), why not keep those two
> options separated in the vote?
>
> a) should be add weak typing
> b) should we also add declare() for to get strict typing at call-site.
>
> If *a* passes it would be a great stepping stone towards adding *b* later
> perhaps, or tweaking internal coercion rules to improve the behavior of the
> weak types, having scalars in return hints (since return hints seem likely
> to pass), etc.
>
> If *b* passes as well great we have a complete picture and every team can
> have declare() Y/N in their own coding guidelines based on preference.
>

Yeah, while the confusion is definitely still there, I would
personally argue that definitely some people who oppose the declare()
get that it's only for calls in the file - and still don't find it
clever.

The potential issues with this are pretty real, to be honest. Simple
things like moving a method from one class to another (let's say to
parent or descendant) and getting to another typing context may cause
unpredictable behavior if the user forgets to have declare() in both
files.


Pavel Kouril