Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80531 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 60555 invoked from network); 15 Jan 2015 11:26:28 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Jan 2015 11:26:28 -0000 Authentication-Results: pb1.pair.com smtp.mail=honey@internot.info; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=honey@internot.info; sender-id=pass Received-SPF: pass (pb1.pair.com: domain internot.info designates 185.57.82.47 as permitted sender) X-PHP-List-Original-Sender: honey@internot.info X-Host-Fingerprint: 185.57.82.47 mail.internot.info Received: from [185.57.82.47] ([185.57.82.47:46192] helo=mail.internot.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 94/87-14306-3E3A7B45 for ; Thu, 15 Jan 2015 06:26:28 -0500 Message-ID: <54B7A3DC.40307@internot.info> Date: Thu, 15 Jan 2015 22:26:20 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 To: internals@lists.php.net References: <1421308977-9413-1-git-send-email-git@internot.info> In-Reply-To: OpenPGP: id=296E6003; url=https://internot.info/docs/gpg_pubkey.asc.gpg Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sN9chPLupqd7L3LetrjplLcehAgDE8s6C" Subject: Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions. From: honey@internot.info (Joshua Rogers) --sN9chPLupqd7L3LetrjplLcehAgDE8s6C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, On 15/01/15 21:49, Xinchen Hui wrote: > do you have a test script to show how to reproduce the error? > > thanks No, I don't. But, if you run `grep -nr do_fstat main/streams/plain_wrapper.c -C3', you can see the result is compared against '0' everywhere else it is used= =2E Thanks, --=20 -- Joshua Rogers --sN9chPLupqd7L3LetrjplLcehAgDE8s6C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUt6PcAAoJEJCcj5QpbmADuLkP/2dqrg53lk3LJewHCFUJMbgD T/NipQ+PrZmDMmb6dB55RKFGXSEuC2Ih4XjL94mUkvQ55tHBEZoMMGcofZL1VLly 8EKFFmOuVMAqFGfhANkP2bCU0tQ8ds+fpv7iEzysAw2ClXLkWC1FBiqV1bL0wC5H z6W9GIZNywUFE4VsxMsA9KU1gSxiaVCBkyPkJP7EoH/ts2/s3Ym9hKR6uvSWD1ZP 5PJBi/syaXZAi5jMzTKo48UWxFuOH1NtNBmKVCpdGxUnX3Nysm0veurJRXD5R5dr jjUvOnUsTTEM4M7C2V1KdJdRk3XNxNJPYplYPtC62rk9sRje/e2edN0ebYGYaPIx 5r1eRTLS5Ht9+Af6ucArkJXldIdCKF+zh2zZiSan+lpQ19GG6G345meJ3dc2PZ0d Ge9ZXlxtVtjikKHeJlRWPJKl4pYW/uYD8faoKdjTb6IrUQ4JmSRku0UR19DrL5De 6FTIhs0UfjFZj3KJJQI0ky5HoQsjqL9xRStUuLjuXdu/lqObDJjj+U1jvTSeqRpA bLQQljhRRHabjAHFNRrQhSbGxnM0PIZYDpV9atpzxtdVIxeIGHZsyLxObIT9aWO5 tJDD/q+eleg/LFKzEW19M6YkNEoQPjta3SJjq3RM+EFVAHQFqg4iYfYYlzjK84eP FYtDogP6aKkEYnoFzpvK =qLoz -----END PGP SIGNATURE----- --sN9chPLupqd7L3LetrjplLcehAgDE8s6C--