Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:8053 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 769 invoked by uid 1010); 22 Feb 2004 17:43:04 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 691 invoked from network); 22 Feb 2004 17:43:04 -0000 Received: from unknown (HELO sapo.pt) (212.55.154.23) by pb1.pair.com with SMTP; 22 Feb 2004 17:43:04 -0000 Received: (qmail 878 invoked from network); 22 Feb 2004 17:43:03 -0000 Received: from unknown (HELO sapo.pt) (10.134.35.156) by relay3 with SMTP; 22 Feb 2004 17:43:03 -0000 Received: (qmail 31068 invoked from network); 22 Feb 2004 17:42:30 -0000 Received: from unknown (HELO pc07653) (nunoplopes@sapo.pt@[81.193.159.235]) (envelope-sender ) by mta6 (qmail-ldap-1.03) with SMTP for ; 22 Feb 2004 17:42:30 -0000 Message-ID: <000601c3f96b$cd157be0$0100a8c0@pc07653> To: , "PHPdev" References: <005201c3f934$b4b98aa0$0100a8c0@pc07653> <200402221219.32181.ilia@prohost.org> Date: Sun, 22 Feb 2004 17:46:25 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1158 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 Subject: Re: [PHP-DEV] [PATCH] fix Warning in image2wbmp From: nlopess@php.net ("Nuno Lopes") Sorry Ilia, but it isn't. Your change only sets the parameter to 0 when you specify an invalid threshold. When you don't specify the threshold, it will throw a warning because the default is -1 (invalid). Nuno > This is already addressed in CVS. > > Ilia > > On February 22, 2004 06:12 am, Nuno Lopes wrote: > > Hello, > > > > Here is a small patch to fix a warning in image2wbmp() when you call that > > function without the optional parameters. > > > > > > Nuno > > > > > > ------------------------- > > reproduce script: > > > $image = imagecreatefrompng('php.png'); > > image2wbmp($image); > > ?>