Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80528 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55834 invoked from network); 15 Jan 2015 11:11:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Jan 2015 11:11:39 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.179 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 209.85.220.179 mail-vc0-f179.google.com Received: from [209.85.220.179] ([209.85.220.179:54920] helo=mail-vc0-f179.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E0/86-14306-A60A7B45 for ; Thu, 15 Jan 2015 06:11:38 -0500 Received: by mail-vc0-f179.google.com with SMTP id le20so4600115vcb.10 for ; Thu, 15 Jan 2015 03:11:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=jVhaHyiSETcK5ZiWBRPK5IzTT0z44Xi9F6pKhggtzRA=; b=FZEC/xHli9DQKMjCmlBsYsOa3iLGNRtCCRiJs3sExqlkiGOlAGn3REKQ8jZ+Ggs2m/ hHeNvNrrSUaSdPDw3t2RiIbZ8nlmXfUv6RDf1Z6r36nzUH+FC5EqWnp6zVHK8GjFgVAx 1GQDJJAoRdcrBXbqJmRfYj3VHVLq8/BatmqphRHXwoVHIdaq52yY0Jpwi6dY5K7Uvx57 ZWT7Ajz6f91ZpFKsaPMe3chwBOjG5C4JlHDHzSio5VZoqEWuYvEjtaLp0E5idn7fKd2K 2HagwE3xbABsfbCjAdNHPA4fs0SwWjxy00EpiK4iwtGsERJhyQbavEJ/2ZjR4V0SzAO4 6xRg== X-Gm-Message-State: ALoCoQkA+S1dkn10Fhw/STWkEKdEAQrgv5Re1YLLBWmE/8WKghmm8U8k6pXMDN6GnqZncINyJ/Oo4E0lbMsmsZ8X4SXCoLANIWdNKrw0tD24zPMArtyi4KkBnr/MlPFI27U+NwreaaSOt6k4tt/wsp2jkt844E+qmA== MIME-Version: 1.0 X-Received: by 10.220.83.193 with SMTP id g1mr5019440vcl.46.1421320295625; Thu, 15 Jan 2015 03:11:35 -0800 (PST) Received: by 10.52.26.40 with HTTP; Thu, 15 Jan 2015 03:11:35 -0800 (PST) In-Reply-To: <1E8DD8EB-D82C-42F4-9A55-4387078EF74A@ajf.me> References: <8C47FA53-0964-49C0-963C-332A936348A5@ajf.me> <68229C26-4EEC-49DC-BA05-D5AC9728D1E8@ajf.me> <93376D88-A704-4F89-AB90-82EEDAE82081@ajf.me> <1E8DD8EB-D82C-42F4-9A55-4387078EF74A@ajf.me> Date: Thu, 15 Jan 2015 15:11:35 +0400 Message-ID: To: Andrea Faulds Cc: Pierre Joye , PHP Internals Content-Type: multipart/alternative; boundary=001a11c2c67a554f0d050caeebfd Subject: Re: [PHP-DEV] [RFC] Big Integer Support From: dmitry@zend.com (Dmitry Stogov) --001a11c2c67a554f0d050caeebfd Content-Type: text/plain; charset=UTF-8 BTW: why not to wrap big integers into special IS_OBJECT? It would keep everything working out of the box (without BIGINT), and would allow to eliminate more than half of unnecessary changes. In the past we made similar decision for closures. Thanks. Dmitry. On Thu, Jan 15, 2015 at 2:01 PM, Andrea Faulds wrote: > Hey Dmitry, > > On 15 Jan 2015, at 07:56, Dmitry Stogov wrote: > > ext/session and ext/json are required by most apps. > Actually I stopped attempts to build it when I saw compilation errors in > ext/session. > > Thanks. Dmitry. > > > Oh dear, does ext/session not build? :/ > > So far I've only built the branch with --disable-all. > > In the case of most extensions, the main source of compilation errors will > be changes to certain Zend Engine functions. In particular, > is_numeric_string_ex needs to support bigints now and has an extra > parameter. I don't think I changed very many other functions. > > Porting extensions should for the most part be relatively simple. Most > extensions are just sets of functions and use zpp. If they're using the 'l' > specifier (Z_PARAM_LONG) they'll continue to work. In most cases there is > no need to update an 'l' parameter to support bigints. The length of a > string can't exceed PHP's max integer size, for example. Of course, there > are some functions where it would have a clear benefit to add bigint > support. > > The main problem with extensions is 'z' > > > > On Thu, Jan 15, 2015 at 10:44 AM, Pierre Joye > wrote: > >> On Thu, Jan 15, 2015 at 8:05 AM, Dmitry Stogov wrote: >> > Oh, it's still in draft state. >> > Too may extensions are missing ext/seesion, ext/json, ext/pdo. >> > Only very simple tests may be done now, and they can't predict impact on >> > real-life applications. >> >> We may as well try to help here. >> >> This patch is anything we want but simple. I really do not want to see >> Andrea going down the pain we had with the 64bit patch. So let >> organize ourselves to avoid that. >> >> Step 1: >> >> Which extensions do we consider as critical to actually get a clue >> about the impact? >> >> I see session, standard ( ;) ), json on top of my head. Which other? >> >> Let help Andrea to port these exts and do the other once we know if >> the RFC is accepted or not. >> >> Cheers, >> Pierre >> > > --001a11c2c67a554f0d050caeebfd--