Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80514
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.192.51 as permitted sender)
Message-ID: <54B74E72.1020902@lerdorf.com>
Date: Wed, 14 Jan 2015 21:21:54 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Xinchen Hui <laruence@php.net>, Julien Pauli <jpauli@php.net>
CC: PHP Internals <internals@lists.php.net>, demon@php.net
References: <CAMUwpuTUP0SUYHeJ6qTTsLFX=YXbsAatZwHgBL5-M3yZs1eHeg@mail.gmail.com> <CABBJUpcFR-OxQufU6=VrTZy1nck-JPVzAc6nOsq2VJxj8q-Agg@mail.gmail.com>
In-Reply-To: <CABBJUpcFR-OxQufU6=VrTZy1nck-JPVzAc6nOsq2VJxj8q-Agg@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="HrgPhtDNROovTJ4ekj6QIFRLiSDoURHRe"
Subject: Re: [PHP-DEV] Top 10 Pecl extensions PHP7 compatibility
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--HrgPhtDNROovTJ4ekj6QIFRLiSDoURHRe
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/14/2015 07:24 PM, Xinchen Hui wrote:
> On Thu, Jan 15, 2015 at 1:53 AM, Julien Pauli <jpauli@php.net> wrote:
>> I obviously will help porting some of them.
> as I remembered,  memcached and redis already be proted by demon at php=
=2Enet

For memcached, do you mean this pull request?

https://github.com/php-memcached-dev/php-memcached/pull/148

It looks pretty good. It is missing the zend_string changes for the INI
stuff, but that came after this was created. So probably a few other
small things to fix up. I thought for sure it would miss this:

- add_assoc_null_ex(return_value, mkeys[i], mkeys_len[i] + 1);
+ add_assoc_null_ex(return_value, mkeys[i], mkeys_len[i]);

But it is in there. I hadn't noticed this pull request and had already
done most of it locally here. I'll merge the two.

-Rasmus


--HrgPhtDNROovTJ4ekj6QIFRLiSDoURHRe
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlS3TnIACgkQlxayKTuqOuCINgCfSbn3HoeP+Z2F9kDqUiV2m7c7
kScAn0ghI7e0n/fsuWE9o2odAXJO5Ybo
=q+Kf
-----END PGP SIGNATURE-----

--HrgPhtDNROovTJ4ekj6QIFRLiSDoURHRe--