Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80513 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 11238 invoked from network); 15 Jan 2015 03:27:13 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Jan 2015 03:27:13 -0000 Authentication-Results: pb1.pair.com smtp.mail=xinchen.h@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@php.net; sender-id=unknown Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.181 as permitted sender) X-PHP-List-Original-Sender: xinchen.h@zend.com X-Host-Fingerprint: 209.85.217.181 mail-lb0-f181.google.com Received: from [209.85.217.181] ([209.85.217.181:64395] helo=mail-lb0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F6/58-00659-F8337B45 for ; Wed, 14 Jan 2015 22:27:13 -0500 Received: by mail-lb0-f181.google.com with SMTP id u14so1722859lbd.12 for ; Wed, 14 Jan 2015 19:27:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=HBoEc1GxsDgC+7UBHGRwaSFpPkQLgWccJvWsUvPsvHo=; b=S0dtiE8GhFTmuM4j/s9PqS40lNmtyAtJFW3akmv+Ap4PEpUrs+pgdkW0fRoXLjJsqd Nb+zcYWqyQfwBYjV2Ht6Xr1L19+8M6U3aPpOX4G2piEoNSun4rTR4DHWPAZZOQF1Yltp aXv4d+R1hffxZz7zuKkv+uyJPhbFLrgT0J0/Z8TUoLk69RKB/keL2ve0B7ssBBCSkKOd J6a1vh+TFq/1iHBS98A3TX9Z58cUItcKVVJvEYul5Ne68a/LM0uLue1eQy4ItgE18J4t YAio60ylS49DkPNRjWobWwh1ZDBfL6fxWpA3ZVlV6Y/ss7efIzg6F/RFCAUGD4dgTcK5 rl5Q== X-Gm-Message-State: ALoCoQlJvQQVnmwB0VzBnxFktVbNbLqAHyAEqqWvvKlYLP+XgYoG9o7/5uCZ/hJz/yavh6OFO08ScOBNdrE0z6BSQ4eeWum6EvEHxfeQsSeCQJCJlN7BcSQ0TxpTc0KjO2L/wKnkqpH8zJK8392iMXbfuc/oWxf7KQ== X-Received: by 10.112.158.40 with SMTP id wr8mr7371355lbb.51.1421292428872; Wed, 14 Jan 2015 19:27:08 -0800 (PST) Received: from mail-la0-f49.google.com (mail-la0-f49.google.com. [209.85.215.49]) by mx.google.com with ESMTPSA id kw10sm90402lac.45.2015.01.14.19.27.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 14 Jan 2015 19:27:07 -0800 (PST) Received: by mail-la0-f49.google.com with SMTP id hs14so11485044lab.8 for ; Wed, 14 Jan 2015 19:27:07 -0800 (PST) X-Received: by 10.152.44.167 with SMTP id f7mr7444891lam.92.1421292427058; Wed, 14 Jan 2015 19:27:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.64.176 with HTTP; Wed, 14 Jan 2015 19:26:46 -0800 (PST) In-Reply-To: References: <54B6CD05.3070005@gmail.com> Date: Thu, 15 Jan 2015 11:26:46 +0800 Message-ID: To: Pierre Joye Cc: Stanislav Malyshev , PHP Internals , Dmitry Stogov , Nikita Popov Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Re: Faster zend sorting implementation From: laruence@php.net (Xinchen Hui) Hey: On Thu, Jan 15, 2015 at 7:52 AM, Pierre Joye wrote: > On Wed, Jan 14, 2015 at 9:09 PM, Stanislav Malyshev wrote: >> Hi! >> >>> I made a PR here: https://github.com/php/php-src/pull/999 for reviewing >>> >>> in benchmark this can brings more than 30% performance gain in >>> array_sort etc functions. >>> >>> tests fails are related to non-stable vs stable sorting difference. >>> >>> anyway, I feel it's better to ask you to do a final review, what >>> do you think? >>> >>> is there any objections to merge this? >> >> I think the sort order of equal elements was never defined, so changing >> it would not be a big issue. The tests, of course, need to be fixed and >> note in UPGRADING should be provided, but otherwise it's fine. > > Same here, all good as long as a notice is present and tests are updated. thanks for the reviewing, I am going to merge it. I have got some ideas to improve based on this patch.. so I'd like to merge it first. thanks -- Xinchen Hui @Laruence http://www.laruence.com/