Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80507
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54B6CD05.3070005@gmail.com>
References: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com>
	<CABBJUpfWmJGDvmKASKnukQEfDSP7L6UaHO10UoRQ3VRbvPwJvA@mail.gmail.com>
	<54B6CD05.3070005@gmail.com>
Date: Thu, 15 Jan 2015 00:52:04 +0100
Message-ID: <CAEZPtU4pxU35cjAAkq-Lse-5srgQKk4f=JzvS1g3MLWp49SLUw@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: Xinchen Hui <laruence@php.net>, PHP Internals <internals@lists.php.net>, 
	Dmitry Stogov <dmitry@zend.com>, Nikita Popov <nikita.ppv@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Re: Faster zend sorting implementation
From: pierre.php@gmail.com (Pierre Joye)

On Wed, Jan 14, 2015 at 9:09 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote:
> Hi!
>
>>     I made a PR here: https://github.com/php/php-src/pull/999 for reviewing
>>
>>     in benchmark this can brings more than 30% performance gain in
>> array_sort etc functions.
>>
>>     tests fails are related to non-stable vs stable sorting difference.
>>
>>     anyway, I feel it's better to ask you to do a final review, what
>> do you think?
>>
>>     is there any objections to merge this?
>
> I think the sort order of equal elements was never defined, so changing
> it would not be a big issue. The tests, of course, need to be fixed and
> note in UPGRADING should be provided, but otherwise it's fine.

Same here, all good as long as a notice is present and tests are updated.